Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LARS initialization is different than pytorch Optimizer in documentation #7

Open
zlenyk opened this issue Apr 9, 2020 · 0 comments

Comments

@zlenyk
Copy link

zlenyk commented Apr 9, 2020

Thanks for creating this repo! It helps me a lot during training.
I wanted to ask/suggest if it was possible the change the initialization of the optimizer to be consistent with pytorch.optim.Optimizer.
In documentation (https://pytorch.org/docs/stable/optim.html) it says that optimizer should be given iterable with params during initialization. Because it's not like that right now, it makes it impossible to use this implementation with for example horovod DistributedOptimizer.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant