Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHART: add an opportunity to setup custom value for dnsPolicy #37

Open
4 tasks done
Boniker opened this issue Jan 24, 2025 · 1 comment
Open
4 tasks done

CHART: add an opportunity to setup custom value for dnsPolicy #37

Boniker opened this issue Jan 24, 2025 · 1 comment
Labels
type/enhancement En enhancement/improvement to an already existing feature

Comments

@Boniker
Copy link

Boniker commented Jan 24, 2025

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here (legacy) and here
  • I've tried installing latest charts and the issue still persists there
  • I'm running a supported version of the application & chart which is listed here

Feature request

Hi Team,

I’d like to contribute to the Kafka-UI Helm chart but currently don’t have access to create a branch for review.

Proposed Implementation:

I’ve identified the need to make the dnsPolicy value customizable in the Deployment for Kafka-UI.
The changes would look like this:

templates/deployment.yaml:

dnsPolicy: {{ .Values.dnsPolicy }}  

values.yaml:

## @param dnsPolicy for Kafka-UI pods  
## ref: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/  
##  
dnsPolicy: "ClusterFirst" 

Additionally, I noticed some trailing spaces during local testing. While not critical, for better code quality.

Expected behavior

dnsPolicy: {{ .Values.dnsPolicy }}  

will allow users to configure the DNS policy directly through values, adding flexibility to the chart.

Your installation details

  1. commit sha: a5d34a702017539ce10300628a508120aa372f58
  2. chart version: 1.4.11
  3. config: as default, nothing special
@Boniker Boniker added the status/triage Issues pending maintainers triage label Jan 24, 2025
@Boniker
Copy link
Author

Boniker commented Jan 24, 2025

@Haarolean apologies for the confusion earlier. It's not an issue but rather a feature request.
However, I couldn't find a template for creating such requests.

@Boniker Boniker changed the title add an opportunity to setup custom value for dnsPolicy CHART: add an opportunity to setup custom value for dnsPolicy Jan 24, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature and removed status/triage Issues pending maintainers triage labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

No branches or pull requests

2 participants