Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageConfig should allow multiple pull secrets #341

Open
jsanda opened this issue Jun 8, 2022 · 0 comments
Open

ImageConfig should allow multiple pull secrets #341

jsanda opened this issue Jun 8, 2022 · 0 comments
Labels
assess Issues in the state 'assess' enhancement New feature or request zh:Assess/Investigate

Comments

@jsanda
Copy link
Contributor

jsanda commented Jun 8, 2022

What is missing?
The ImageConfig API is to provide image configuration defaults that are supplied in a ConfigMap that look like this:

apiVersion: v1
data:
  controller_manager_config.yaml: |
    apiVersion: config.k8ssandra.io/v1beta1
    kind: OperatorConfig
    metadata:
      name: operator-config
    health:
      healthProbeBindAddress: :8081
    metrics:
      bindAddress: 127.0.0.1:8080
    webhook:
      port: 9443
    leaderElection:
      leaderElect: true
      resourceName: b569adb7.cassandra.datastax.com
    disableWebhooks: false
    imageConfigFile: /configs/image_config.yaml
  image_config.yaml: |
    apiVersion: config.k8ssandra.io/v1beta1
    kind: ImageConfig
    metadata:
      name: image-config
    images:
      system-logger: "k8ssandra/system-logger:v1.10.0"
      config-builder: "datastax/cass-config-builder:1.0.4-ubi7"
      # cassandra:
      #   "4.0.0": "k8ssandra/cassandra-ubi:latest"
      # dse:
      #   "6.8.999": "datastax/dse-server-prototype:latest"
    # imageRegistry: "localhost:5000"
    # imagePullPolicy: Always
    # imagePullSecret:
    #   name: my-secret-pull-registry
    defaults:
      # Note, postfix is ignored if repository is not set
      cassandra:
        repository: "k8ssandra/cass-management-api"
      dse:
        repository: "datastax/dse-server"
        suffix: "-ubi7"
kind: ConfigMap
metadata:
  creationTimestamp: "2022-05-25T13:08:53Z"
  name: cass-operator-manager-config
  namespace: k8ssandra-operator
  resourceVersion: "1471"
  uid: 9b74d066-141f-4acc-ad8e-9a0ddbfc38b5

As explained in the Kubernetes docs you can specify multiple image pull secrets for a pod.

Why do we need it?
To be consistent we should support multiple pull secrets in the ImageConfig API.

Environment

  • Cass Operator version:

    1.11.0

    **Anything else we need to know?**:

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-41

@jsanda jsanda added the enhancement New feature or request label Jun 8, 2022
@sync-by-unito sync-by-unito bot changed the title ImageConfig should allow multiple pull secrets K8SSAND-1545 ⁃ ImageConfig should allow multiple pull secrets Jun 8, 2022
@adejanovski adejanovski moved this to Assess/Investigate in K8ssandra Nov 8, 2022
@adejanovski adejanovski added the assess Issues in the state 'assess' label Sep 3, 2024
@sync-by-unito sync-by-unito bot changed the title K8SSAND-1545 ⁃ ImageConfig should allow multiple pull secrets ImageConfig should allow multiple pull secrets Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assess Issues in the state 'assess' enhancement New feature or request zh:Assess/Investigate
Projects
No open projects
Status: Assess/Investigate
Development

No branches or pull requests

2 participants