Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent API for image configurations #294

Open
Miles-Garnsey opened this issue Mar 9, 2022 · 2 comments
Open

Consistent API for image configurations #294

Miles-Garnsey opened this issue Mar 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Miles-Garnsey
Copy link
Member

Miles-Garnsey commented Mar 9, 2022

What is missing?

K8ssandra operator now has an Image struct which is a structured API for setting image configurations (including the ability to specify different docker credentials for each image).

It would be good if cass-operator used the same mechanism for consistency and to ensure that creds can be set. At present, the image fields are strings.

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: CASS-46

@Miles-Garnsey Miles-Garnsey added the enhancement New feature or request label Mar 9, 2022
@sync-by-unito sync-by-unito bot changed the title Consistent API for image configurations K8SSAND-1313 ⁃ Consistent API for image configurations Mar 9, 2022
@jimdickinson
Copy link
Contributor

Why is an image string field not good enough? This is the standard across many k8s projects, and I would actually advise to simplify all the image stuff for cassdc to "the user must pass an image string, and it is used"

@Miles-Garnsey
Copy link
Member Author

@jimdickinson, you're entirely correct in saying that Pods, Deployments et al. all use strings to specify images. The thrust of this ticket is that the mechanism should be consistent.

k8ssandra-operator has introduced a struct image field, which does have the advantage of allowing different docker creds per image.

Whether it makes sense to allow different docker registry creds per container I'm unsure - I don't know if k8s actually supports specifying multiple credentials for a single pod, now you ask the the question.

@adejanovski adejanovski moved this to To Groom in K8ssandra Nov 8, 2022
@sync-by-unito sync-by-unito bot changed the title K8SSAND-1313 ⁃ Consistent API for image configurations Consistent API for image configurations Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants