Skip to content

Move "Edit station" button away from approval status#38

Merged
xylo04 merged 2 commits into
mainfrom
copilot/move-edit-button-for-station-details
May 29, 2026
Merged

Move "Edit station" button away from approval status#38
xylo04 merged 2 commits into
mainfrom
copilot/move-edit-button-for-station-details

Conversation

Copilot AI commented May 29, 2026

Copy link
Copy Markdown
Contributor

The admin "Edit station" button was positioned in matListItemMeta alongside the per-user approval status badges, visually implying that editing a station requires approval.

Changes

  • Moves the "Edit station" button out of matListItemMeta and into a dedicated matListItemLine below the station description, grouping it with the station's own details rather than with the access/approval status.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 29, 2026

Copy link
Copy Markdown

Deploying station-reservation with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec746ac
Status: ✅  Deploy successful!
Preview URL: https://e3012d8a.station-reservation.pages.dev
Branch Preview URL: https://copilot-move-edit-button-for.station-reservation.pages.dev

View logs

@supabase

supabase Bot commented May 29, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project cpibdotiiptojhawnpff because there are no changes detected in backend/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@xylo04

xylo04 commented May 29, 2026

Copy link
Copy Markdown
Member

@copilot the edit button text is not visible because the bottom of the row is being cut off. I can just barely see the hover highlight.
image

Copilot AI commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot the edit button text is not visible because the bottom of the row is being cut off. I can just barely see the hover highlight.
<img width="2505" height="1928" alt="image" src="https://githu...

Fixed in the latest commit. The lines="3" was capping the list item height and clipping the extra line added for the edit button. Changed it to [lines]="isClubAdmin() ? 4 : 3" so admins get the extra height to accommodate the button.

Copilot finished work on behalf of xylo04 May 29, 2026 01:07
Copilot AI requested a review from xylo04 May 29, 2026 01:07
@xylo04 xylo04 marked this pull request as ready for review May 29, 2026 01:08
@xylo04 xylo04 merged commit dd9ea65 into main May 29, 2026
4 checks passed
@xylo04 xylo04 deleted the copilot/move-edit-button-for-station-details branch May 29, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants