Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration #22

Open
4 tasks
justinba1010 opened this issue Mar 29, 2019 · 7 comments
Open
4 tasks

Continuous Integration #22

justinba1010 opened this issue Mar 29, 2019 · 7 comments
Labels
ci Continuous Integration

Comments

@justinba1010
Copy link

justinba1010 commented Mar 29, 2019

Going to make this a meta issue - Joshua

Check the server

  • compiles (make)
  • works (make test)
  • is memory safe (make valgrind). It would be wonderful it this were a part of make test in the future.
  • is reasonably performant under heavy load

Original comment:

I can go ahead and set up some unit tests with TravisCI or CircleCI(I'm more experienced with CI), if you'd like to add some continuous integration to this project.  - Justin
@jyn514
Copy link
Owner

jyn514 commented Mar 29, 2019

Is circleci free?

That would be great, thanks! You should be able to run make test, if that exits with 0 the build succeeded.

@justinba1010
Copy link
Author

Ya, I'll try and get that up and running. It is free for up to 1000 build minutes. I'll try to make it so only PRs get the CI.

@justinba1010
Copy link
Author

Is there any target we should be aiming for?

@jyn514
Copy link
Owner

jyn514 commented Mar 29, 2019

1000 per month, got it. Not sure what you mean by target, but if you run make test all the tests will run.

If you want to add CI for master that would be great as well.

@justinba1010
Copy link
Author

Like what OS to test on.

@jyn514
Copy link
Owner

jyn514 commented Mar 30, 2019

Oh! Yes I'd like to test OSX, FreeBSD, and Ubuntu 18.04.

@jyn514 jyn514 mentioned this issue Apr 10, 2019
3 tasks
@jyn514
Copy link
Owner

jyn514 commented Apr 10, 2019

I started working on this in the cirrusci branch, I chose them because

  • docker is reproducible
  • they support BSD, which CircleCI doesn't
  • they have free builds for open source

Will update this later today, I have unpushed changes.

@jyn514 jyn514 added the ci Continuous Integration label Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

No branches or pull requests

2 participants