Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get url-encoding working #12

Open
jyn514 opened this issue Mar 17, 2019 · 2 comments
Open

Get url-encoding working #12

jyn514 opened this issue Mar 17, 2019 · 2 comments
Labels
core core feature

Comments

@jyn514
Copy link
Owner

jyn514 commented Mar 17, 2019

No description provided.

@jyn514 jyn514 added the core core feature label Mar 17, 2019
@jyn514
Copy link
Owner Author

jyn514 commented Mar 17, 2019

This will be a pain because then we have to treat URLs as arbitrary binary instead of strings (because /%00blah.pdf) is a valid url

@jyn514
Copy link
Owner Author

jyn514 commented Mar 29, 2019

I think adding an explicit length parameter for the url is the way to go. That means we can't use string library functions for the url. Would be nice to know if nulls are allowed or if we can just strip them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core core feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jyn514