Item ID vs Translation String

[dosluke]

hey you have a .tolowercase call on one side of a check but not the other which causes things to fail. string pattern=orString.tolower BUT NOT when final String itemName = in the following function which i believe is the cause of an error im seeing where stuff is randomly not matched in random situations

private boolean canItemPassHopper(final String hopperName, final ItemStack item) {
if (hopperName == null) return true;

    nextCondition: for (final String condition : hopperName.split(",")) {
        nextAnd: for (final String andString : condition.split("&")) {
            for (final String orString : andString.split("\\|")) {
                final String pattern = orString.toLowerCase().strip();
                if (canItemPassPattern(pattern, item)) continue nextAnd;
            }
            continue nextCondition;
        }
        return true;
    }

    return false;
}

private boolean canItemPassPattern(final String pattern, final ItemStack item) {
    final String itemName = item.getType().getKey().getKey();

[dosluke]

yeah in my case im trying to match ^Raw for raw porkchop, etc, but it will always fail because str.startswith(raw) will failr when the string starts with "Raw"

[dosluke]

ok i did some debugging and weather or not lowercase is the issue, ive learned that item.getType().getKey().getKey().toLowerCase(); produces "porkchop" instead of "raw porkchop".. which ig is item id instead of how its displayed in the popup?

[jwkerr]

Could you link to the exact lines you believe are causing issues for me? @dosluke

[dosluke]

its the following two functions (slightly modified). but i want to match "raw porkchop" "raw mutton" etc, but those are translation strings i think? the method you are using to get their name returns "porkchop" and "mutton" which i believe are their ID, which is NOT how they show up in game.

this line gets their id. for example what is displayed as "raw porkchop" in game, this returns "porkchop". I know this cause i modified,built the code, tested it printing each of its tests to the servers command line.

final String itemName = item.getType().getKey().getKey().toLowerCase();

here are the functions. Ive moved the itemname initialization to the top function so its not being reinitialized for each test case.

private boolean canItemPassHopper(final String hopperName, final ItemStack item) {
if (hopperName == null) return true;

    final String itemName = item.getType().getKey().getKey().toLowerCase();

    nextCondition: for (final String condition : hopperName.split(",")) {
        nextAnd: for (final String andString : condition.split("&")) {
            for (final String orString : andString.split("\\|")) {
                final String pattern = orString.toLowerCase().strip();
                if (canItemPassPattern(pattern, item, itemName)) continue nextAnd;
            }
            continue nextCondition;
        }
        return true;
    }

    return false;
}

private boolean canItemPassPattern(final String pattern, final ItemStack item, String itemName) {

    //System.out.println("TEST: " + itemName + " VS " + pattern);
    if (pattern.isEmpty() || pattern.equals(itemName)) return true;

    final char prefix = pattern.charAt(0); // The character at the start of the pattern
    final String string = pattern.substring(1); // Anything after the prefix
    return switch (prefix) {
        case '!' -> !canItemPassPattern(string, item, itemName); // NOT operator
        case '*' -> itemName.contains(string); // Contains specified pattern
        case '^' -> itemName.startsWith(string); // Starts with specified pattern
        case '$' -> itemName.endsWith(string); // Ends with specified pattern
        case '#' -> { // Item has specified tag
            final NamespacedKey key = NamespacedKey.fromString(string);
            if (key == null) yield false;

            Tag<Material> tag = Bukkit.getTag(Tag.REGISTRY_BLOCKS, key, Material.class);
            if (tag == null) tag = Bukkit.getTag(Tag.REGISTRY_ITEMS, key, Material.class);

            yield tag != null && tag.isTagged(item.getType());
        }
        case '~' -> doesItemHaveSpecifiedPotionEffect(item, string); // Item has specified potion effect
        case '+' -> doesItemHaveSpecifiedEnchantment(item, string); // Item has specified enchantment
        case '=' -> { // Item has specified name (including renames)
            String displayName = PlainTextComponentSerializer.plainText().serialize(item.displayName())
                    .toLowerCase()
                    .replaceAll(" ", "_");

            displayName = displayName.substring(1, displayName.length() - 1);

            yield displayName.equals(string);
        }
        default -> false;
    };
} 

[dosluke]

line 143 in your code

https://github.com/jwkerr/HopperFilter/blob/master/src/main/java/net/earthmc/hopperfilter/listener/InventoryActionListener.java

[jwkerr]

I'm not sure what you think is an issue exactly, I just made a hopper named porkchop, threw a porkchop in and it only allows that, as intended.

The call to String#toLowerCase is just to clean up the filter for comparison. Leading and trailing whitespace are also removed.

That means that Porkchop, Cooked_Porkchop, Brick and porkchop,cooked_porkchop,brick are identical in function.

[dosluke]

My game displays "raw porkchop" when you look at the porkchop. I didnt realize the id would be different from thr display name when i made this issue. So I was trying to match ^raw to get raw porkchop raw mutton filtered. The problem is the game says raw porkchop but the I'd says porkchop.

[dosluke]

yeah its my fault when i made this issue i just assumed it was a capitalization problem..

[dosluke]

i guess it would be cool if it was possible to choose to use the display name or the ID? because if im understanding your code correctly, right now id have to match the display name exactly. but im trying to match ^raw to get several raw foods.

[jwkerr]

Press F3+H and then hover an item. @dosluke

[jwkerr]

i guess it would be cool if it was possible to choose to use the display name or the ID? because if im understanding your code correctly, right now id have to match the display name exactly. but im trying to match ^raw to get several raw foods.

The = operator might be more like what you want, but not sure how it functions with vanilla names. If it does work, you would need the entire name, and that might not work with spaces, if it does it would be because I converted spaces to _ probably so try =Raw_Porkchop if you want, or maybe =Raw Porkchop would work? I'm not really sure.

https://github.com/jwkerr/HopperFilter/wiki/Syntax

In the future I want to fully rewrite the "language" of this plugin to make it much more usable and extendable.

[dosluke]

Ok.. I'm going to change it around for my own purposes since I already have it downloaded and buildable. Funny enough I just made something similar as a command line tool for Linux, want me to forward the result of this plugin modification to you?

[dosluke]

idk enuf about java to know if it supports lambdas or passing functions as parameters but if you want extensibility, you could have a rule dictionary which could be added to. or you could have a simple plugin like system where theres a test case if that rule class should be used and then a way to call it. but the following is what im going to be running which allows my prefered method testing the display name of the item with the possibility of using "ID:" to reference its ID name. thanks for your help!

sidenote, a fun way to support many more test cases in each hopper other than the (50?) char limit would be to hold a book in the hopper, or maybe write a book with your test cases, rename the book to [RULES] or something, then throw it into the hopper. the hopper should be able to read the book and store the rules in an internal field, it would just have to worry about saving the data when the server is off.

private boolean canItemPassHopper(final String hopperName, final ItemStack item) {
if (hopperName == null) return true;

    String itemID = item.getType().getKey().getKey().toLowerCase();

    String itemName = PlainTextComponentSerializer.plainText().serialize(item.displayName()).toLowerCase();

            itemName = itemName.substring(1, itemName.length() - 1);

    nextCondition: for (final String condition : hopperName.split(",")) {
        nextAnd: for (final String andString : condition.split("&")) {
            for (final String orString : andString.split("\\|")) {
                final String pattern = orString.toLowerCase();
                if (canItemPassPattern(pattern, item, itemName, itemID)) continue nextAnd;
            }
            continue nextCondition;
        }
        return true;
    }

    return false;
}

private boolean canItemPassPattern(String pattern, final ItemStack item, String itemName, String itemID) {

    String testStr = itemName;

    //System.out.println("TEST: " + itemName + " VS " + pattern);
    if (pattern.isEmpty() || pattern.equals(testStr)) return true;

    if (pattern.startsWith("ID:"))
    {
        pattern = pattern.substring(3);
        testStr = itemID;
    }

    final char prefix = pattern.charAt(0); // The character at the start of the pattern
    final String patternText = pattern.substring(1); // Anything after the prefix

    return switch (prefix) {
        case '!' -> !canItemPassPattern(patternText, item, testStr, itemID); // NOT operator
        case '*' -> testStr.contains(patternText); // Contains specified pattern
        case '^' -> testStr.startsWith(patternText); // Starts with specified pattern
        case '$' -> testStr.endsWith(patternText); // Ends with specified pattern
        case '#' -> { // Item has specified tag
            final NamespacedKey key = NamespacedKey.fromString(patternText);
            if (key == null) yield false;

            Tag<Material> tag = Bukkit.getTag(Tag.REGISTRY_BLOCKS, key, Material.class);
            if (tag == null) tag = Bukkit.getTag(Tag.REGISTRY_ITEMS, key, Material.class);

            yield tag != null && tag.isTagged(item.getType());
        }
        case '~' -> doesItemHaveSpecifiedPotionEffect(item, patternText); // Item has specified potion effect
        case '+' -> doesItemHaveSpecifiedEnchantment(item, patternText); // Item has specified enchantment

        default -> false;
    };
}

[dosluke]

ive changed it around a bunch more to act how i would like. given the license i may post my own version, with credit. any considerations or anything i need to do? i know i gotta include the license.