Merge pull request #477 from justcoding121/master

Beta

Author: justcoding121

Titanium.Web.Proxy/Http/ConnectRequest.cs

@@ -2,6 +2,9 @@
 
 namespace Titanium.Web.Proxy.Http
 {
+    /// <summary>
+    /// The tcp tunnel Connect request.
+    /// </summary>
     public class ConnectRequest : Request
     {
         public ConnectRequest()

Titanium.Web.Proxy/Http/ConnectResponse.cs

@@ -4,6 +4,9 @@
 
 namespace Titanium.Web.Proxy.Http
 {
+    /// <summary>
+    /// The tcp tunnel connect response object.
+    /// </summary>
     public class ConnectResponse : Response
     {
         public ServerHelloInfo ServerHelloInfo { get; set; }

Titanium.Web.Proxy/Http/HeaderCollection.cs

@@ -8,6 +8,9 @@
 
 namespace Titanium.Web.Proxy.Http
 {
+    /// <summary>
+    /// The http header collection.
+    /// </summary>
     [TypeConverter(typeof(ExpandableObjectConverter))]
     public class HeaderCollection : IEnumerable<HttpHeader>
     {

Titanium.Web.Proxy/Http/KnownHeaders.cs

@@ -1,5 +1,8 @@
 namespace Titanium.Web.Proxy.Http
 {
+    /// <summary>
+    /// Well known http headers.
+    /// </summary>
     public static class KnownHeaders
     {
         // Both

Titanium.Web.Proxy/Http/RequestResponseBase.cs

@@ -10,6 +10,9 @@
 
 namespace Titanium.Web.Proxy.Http
 {
+    /// <summary>
+    /// Abstract base class for similar objects shared by both request and response objects.
+    /// </summary>
     public abstract class RequestResponseBase
     {
         /// <summary>

Titanium.Web.Proxy/Http/Responses/GenericResponse.cs

@@ -4,7 +4,7 @@
 namespace Titanium.Web.Proxy.Http.Responses
 {
     /// <summary>
-    /// Anything other than a 200 or 302 response
+    /// Anything other than a 200 or 302 http response.
     /// </summary>
     public class GenericResponse : Response
     {

Titanium.Web.Proxy/Http/Responses/OkResponse.cs

@@ -3,7 +3,7 @@
 namespace Titanium.Web.Proxy.Http.Responses
 {
     /// <summary>
-    ///     200 Ok response
+    ///     The http 200 Ok response.
     /// </summary>
     public sealed class OkResponse : Response
     {

Titanium.Web.Proxy/Http/Responses/RedirectResponse.cs

@@ -3,7 +3,7 @@
 namespace Titanium.Web.Proxy.Http.Responses
 {
     /// <summary>
-    ///     Redirect response
+    ///     The http redirect response.
     /// </summary>
     public sealed class RedirectResponse : Response
     {

Titanium.Web.Proxy/Network/Tcp/TcpConnectionFactory.cs

@@ -277,7 +277,7 @@ private async Task<TcpServerConnection> createServerConnection(string remoteHost
                 };
 
                 //linux has a bug with socket reuse in .net core.
-                if (proxyServer.ReuseSocket && !RunTime.IsLinux)
+                if (proxyServer.ReuseSocket && RunTime.IsWindows || RunTime.IsRunningOnMono)
                 {
                     tcpClient.Client.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true);
                 }

Titanium.Web.Proxy/ProxyServer.cs

@@ -193,7 +193,7 @@ public ProxyServer(string rootCertificateName, string rootCertificateIssuerName,
 
         /// <summary>
         /// Should we reuse client/server tcp sockets.
-        /// Default is true (false for linux due to bug in .Net core).
+        /// Default is true (disabled for linux/macOS due to bug in .Net core).
         /// </summary>
         public bool ReuseSocket { get; set; } = true;
 
@@ -617,8 +617,8 @@ private void listen(ProxyEndPoint endPoint)
         {
             endPoint.Listener = new TcpListener(endPoint.IpAddress, endPoint.Port);
 
-            //linux has a bug with socket reuse in .net core.
-            if (ReuseSocket && !RunTime.IsLinux)
+            //linux/macOS has a bug with socket reuse in .net core.
+            if (ReuseSocket && (RunTime.IsWindows || RunTime.IsRunningOnMono))
             {
                 endPoint.Listener.Server.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true);
             }