Skip to content
This repository was archived by the owner on Jul 9, 2023. It is now read-only.

Commit 9af29e8

Browse files
committed
#184 dispose args
1 parent 5d461f5 commit 9af29e8

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

Titanium.Web.Proxy/Http/HttpWebClient.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,10 @@ public void Dispose()
218218
//but just to be on safe side
219219
Request.RequestBody = null;
220220
Response.ResponseBody = null;
221+
222+
Request.RequestBodyString = null;
223+
Response.ResponseBodyString = null;
224+
221225
}
222226
}
223227
}

Titanium.Web.Proxy/RequestHandler.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,7 @@ private async Task<bool> HandleHttpSessionRequest(TcpClient client, string httpC
460460
await CheckAuthorization(clientStreamWriter,
461461
args.WebSession.Request.RequestHeaders.Values) == false)
462462
{
463+
args.Dispose();
463464
break;
464465
}
465466

@@ -480,6 +481,7 @@ await TcpHelper.SendRaw(this,
480481
httpCmd, httpVersion, args.WebSession.Request.RequestHeaders, args.IsHttps,
481482
clientStream, tcpConnectionFactory);
482483

484+
args.Dispose();
483485
break;
484486
}
485487

@@ -494,20 +496,25 @@ await TcpHelper.SendRaw(this,
494496
if (disposed)
495497
{
496498
//already disposed inside above method
499+
args.Dispose();
497500
break;
498501
}
499502

500503
if (args.WebSession.Request.CancelRequest)
501504
{
505+
args.Dispose();
502506
break;
503507
}
504508

505509
//if connection is closing exit
506510
if (args.WebSession.Response.ResponseKeepAlive == false)
507511
{
512+
args.Dispose();
508513
break;
509514
}
510515

516+
args.Dispose();
517+
511518
// read the next request
512519
httpCmd = await clientStreamReader.ReadLineAsync();
513520
}

Titanium.Web.Proxy/ResponseHandler.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,6 @@ await args.WebSession.ServerConnection.StreamReader
133133
return true;
134134
}
135135

136-
args.Dispose();
137-
138136
return false;
139137
}
140138

0 commit comments

Comments
 (0)