make the line shorter (and cast only once :) )

honfika · honfika · commit 5e8daf5b5706 · 2018-02-10T16:15:54.000+01:00
diff --git a/Titanium.Web.Proxy/Helpers/Tcp.cs b/Titanium.Web.Proxy/Helpers/Tcp.cs
@@ -30,14 +30,14 @@ internal static TcpTable GetExtendedTcpTable(IpVersion ipVersion)
             int tcpTableLength = 0;
 
             int ipVersionValue = ipVersion == IpVersion.Ipv4 ? NativeMethods.AfInet : NativeMethods.AfInet6;
+            int allPid = (int)NativeMethods.TcpTableType.OwnerPidAll;
 
-            if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) != 0)
+            if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, allPid, 0) != 0)
             {
                 try
                 {
                     tcpTable = Marshal.AllocHGlobal(tcpTableLength);
-                    if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) ==
-                        0)
+                    if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, allPid, 0) == 0)
                     {
                         var table = (NativeMethods.TcpTable)Marshal.PtrToStructure(tcpTable, typeof(NativeMethods.TcpTable));
 
@@ -72,14 +72,14 @@ internal static TcpRow GetTcpRowByLocalPort(IpVersion ipVersion, int localPort)
             int tcpTableLength = 0;
 
             int ipVersionValue = ipVersion == IpVersion.Ipv4 ? NativeMethods.AfInet : NativeMethods.AfInet6;
+            int allPid = (int)NativeMethods.TcpTableType.OwnerPidAll;
 
-            if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) != 0)
+            if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, allPid, 0) != 0)
             {
                 try
                 {
                     tcpTable = Marshal.AllocHGlobal(tcpTableLength);
-                    if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) ==
-                        0)
+                    if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, allPid, 0) == 0)
                     {
                         var table = (NativeMethods.TcpTable)Marshal.PtrToStructure(tcpTable, typeof(NativeMethods.TcpTable));
 

Original file line number	Diff line number	Diff line change
`@@ -30,14 +30,14 @@ internal static TcpTable GetExtendedTcpTable(IpVersion ipVersion)`
`30`	`30`	`int tcpTableLength = 0;`
`31`	`31`
`32`	`32`	`int ipVersionValue = ipVersion == IpVersion.Ipv4 ? NativeMethods.AfInet : NativeMethods.AfInet6;`
	`33`	`+ int allPid = (int)NativeMethods.TcpTableType.OwnerPidAll;`
`33`	`34`
`34`		`- if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) != 0)`
	`35`	`+ if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, allPid, 0) != 0)`
`35`	`36`	`{`
`36`	`37`	`try`
`37`	`38`	`{`
`38`	`39`	`tcpTable = Marshal.AllocHGlobal(tcpTableLength);`
`39`		`- if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) ==`
`40`		`- 0)`
	`40`	`+ if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, allPid, 0) == 0)`
`41`	`41`	`{`
`42`	`42`	`var table = (NativeMethods.TcpTable)Marshal.PtrToStructure(tcpTable, typeof(NativeMethods.TcpTable));`
`43`	`43`
`@@ -72,14 +72,14 @@ internal static TcpRow GetTcpRowByLocalPort(IpVersion ipVersion, int localPort)`
`72`	`72`	`int tcpTableLength = 0;`
`73`	`73`
`74`	`74`	`int ipVersionValue = ipVersion == IpVersion.Ipv4 ? NativeMethods.AfInet : NativeMethods.AfInet6;`
	`75`	`+ int allPid = (int)NativeMethods.TcpTableType.OwnerPidAll;`
`75`	`76`
`76`		`- if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) != 0)`
	`77`	`+ if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, false, ipVersionValue, allPid, 0) != 0)`
`77`	`78`	`{`
`78`	`79`	`try`
`79`	`80`	`{`
`80`	`81`	`tcpTable = Marshal.AllocHGlobal(tcpTableLength);`
`81`		`- if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, (int)NativeMethods.TcpTableType.OwnerPidAll, 0) ==`
`82`		`- 0)`
	`82`	`+ if (NativeMethods.GetExtendedTcpTable(tcpTable, ref tcpTableLength, true, ipVersionValue, allPid, 0) == 0)`
`83`	`83`	`{`
`84`	`84`	`var table = (NativeMethods.TcpTable)Marshal.PtrToStructure(tcpTable, typeof(NativeMethods.TcpTable));`
`85`	`85`