Merge pull request #465 from justcoding121/master

retry without polly fixes

Author: justcoding121

Titanium.Web.Proxy/Network/RetryPolicy.cs

@@ -32,9 +32,9 @@ internal async Task<RetryResult> ExecuteAsync(Func<TcpServerConnection, Task<boo
             Exception exception = null;
 
             var attempts = retries;
-            while (attempts >= 0)
+
+            while (true)
             {
-                
                 try
                 {
                     //setup connection
@@ -44,26 +44,29 @@ internal async Task<RetryResult> ExecuteAsync(Func<TcpServerConnection, Task<boo
                     @continue = await action(currentConnection);
 
                 }
-                catch (T ex)
-                {
+                catch (Exception ex)
+                {     
                     exception = ex;
-                    await onRetry(ex);
                 }
 
-                if(exception == null)
+                attempts--;
+
+                if (attempts < 0
+                    || exception == null
+                    || !(exception is T))
                 {
                     break;
                 }
 
                 exception = null;
-                attempts--;
+                await disposeConnection();         
             }
 
             return new RetryResult(currentConnection, exception, @continue);
         }
 
         //before retry clear connection
-        private async Task onRetry(Exception ex)
+        private async Task disposeConnection()
         {
             if (currentConnection != null)
             {

Titanium.Web.Proxy/RequestHandler.cs

@@ -267,7 +267,8 @@ await handleWebSocketUpgrade(httpCmd, args, request,
                             //between sessions without using it.
                             //Do not release authenticated connections for performance reasons.
                             //Otherwise it will keep authenticating per session.
-                            if (EnableConnectionPool && !connection.IsWinAuthenticated)
+                            if (EnableConnectionPool && connection!=null
+                                && !connection.IsWinAuthenticated)
                             {
                                 await tcpConnectionFactory.Release(connection);
                                 connection = null;