Excluded => !DecryptSsl (#407)

Author: honfika

Examples/Titanium.Web.Proxy.Examples.Basic/ProxyTestController.cs

@@ -80,8 +80,6 @@ public void StartProxy()
 
             explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 8000)
             {
-                //You can set only one of the ExcludedHttpsHostNameRegex and IncludedHttpsHostNameRegex properties, otherwise ArgumentException will be thrown
-
                 //Use self-issued generic certificate on all https requests
                 //Optimizes performance by not creating a certificate for each https-enabled domain
                 //Useful when certificate trust is not required by proxy clients
@@ -152,7 +150,7 @@ private async Task OnBeforeTunnelConnectRequest(object sender, TunnelConnectSess
                 //Exclude Https addresses you don't want to proxy
                 //Useful for clients that use certificate pinning
                 //for example dropbox.com
-                e.Excluded = true;
+                e.DecryptSsl = false;
             }
         }
 

Examples/Titanium.Web.Proxy.Examples.Wpf/MainWindow.xaml.cs

@@ -119,7 +119,7 @@ private async Task ProxyServer_BeforeTunnelConnectRequest(object sender, TunnelC
             string hostname = e.WebSession.Request.RequestUri.Host;
             if (hostname.EndsWith("webex.com"))
             {
-                e.Excluded = true;
+                e.DecryptSsl = false;
             }
 
             await Dispatcher.InvokeAsync(() =>

README.md

@@ -66,8 +66,6 @@ proxyServer.ClientCertificateSelectionCallback += OnCertificateSelection;
 
 var explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 8000, true)
 {
-//You can set only one of the ExcludedHttpsHostNameRegex and IncludedHttpsHostNameRegex properties, otherwise ArgumentException will be thrown
-
 //Use self-issued generic certificate on all https requests
 //Optimizes performance by not creating a certificate for each https-enabled domain
 //Useful when certificate trust is not required by proxy clients
@@ -135,7 +133,7 @@ private async Task OnBeforeTunnelConnectRequest(object sender, TunnelConnectSess
          //Exclude Https addresses you don't want to proxy
          //Useful for clients that use certificate pinning
          //for example dropbox.com
-         e.Excluded = true;
+         e.DecryptSsl = false;
     }
 }
 

Titanium.Web.Proxy/EventArguments/TunnelConnectEventArgs.cs

@@ -6,7 +6,7 @@ namespace Titanium.Web.Proxy.EventArguments
 {
     public class TunnelConnectSessionEventArgs : SessionEventArgs
     {
-        public bool Excluded { get; set; }
+        public bool DecryptSsl { get; set; } = true;
 
         public bool IsHttpsConnect { get; internal set; }
 

Titanium.Web.Proxy/Models/ExplicitProxyEndPoint.cs

@@ -25,7 +25,7 @@ public class ExplicitProxyEndPoint : ProxyEndPoint
         /// <summary>
         /// Intercept tunnel connect request
         /// Valid only for explicit endpoints
-        /// Set the <see cref="TunnelConnectSessionEventArgs.Excluded"/> property to true if this HTTP connect request should'nt be decrypted and instead be relayed
+        /// Set the <see cref="TunnelConnectSessionEventArgs.DecryptSsl"/> property to false if this HTTP connect request should'nt be decrypted and instead be relayed
         /// </summary>
         public event AsyncEventHandler<TunnelConnectSessionEventArgs> BeforeTunnelConnectRequest;
 

Titanium.Web.Proxy/RequestHandler.cs

@@ -79,7 +79,7 @@ private async Task HandleClient(ExplicitProxyEndPoint endPoint, TcpClient tcpCli
                     await endPoint.InvokeBeforeTunnelConnectRequest(this, connectArgs, ExceptionFunc);
 
                     //filter out excluded host names
-                    bool excluded = !endPoint.DecryptSsl || connectArgs.Excluded;
+                    bool decryptSsl = endPoint.DecryptSsl && connectArgs.DecryptSsl;
 
                     if (await CheckAuthorization(connectArgs) == false)
                     {
@@ -109,7 +109,7 @@ private async Task HandleClient(ExplicitProxyEndPoint endPoint, TcpClient tcpCli
 
                     await endPoint.InvokeBeforeTunnectConnectResponse(this, connectArgs, ExceptionFunc, isClientHello);
 
-                    if (!excluded && isClientHello)
+                    if (decryptSsl && isClientHello)
                     {
                         connectRequest.RequestUri = new Uri("https://" + httpUrl);
 
@@ -143,12 +143,12 @@ private async Task HandleClient(ExplicitProxyEndPoint endPoint, TcpClient tcpCli
                         if (await HttpHelper.IsConnectMethod(clientStream) == -1)
                         {
                             // It can be for example some Google (Cloude Messaging for Chrome) magic
-                            excluded = true;
+                            decryptSsl = false;
                         }
                     }
 
                     //Hostname is excluded or it is not an HTTPS connect
-                    if (excluded || !isClientHello)
+                    if (!decryptSsl || !isClientHello)
                     {
                         //create new connection
                         using (var connection = await GetServerConnection(connectArgs, true))