feat #396 : Create Experiments From Overrides #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushjain17
reviewed
Jan 30, 2025
| @@ -228,6 +229,8 @@ pub fn context_override() -> impl IntoView { | |||
| } | |||
| }, | |||
| ); | |||
| let (_reset_exp_form, set_exp_form) = create_signal(0); | |||
There was a problem hiding this comment.
do we really need this signal ?
the data is not being read anywhere
There was a problem hiding this comment.
oh yeah, that state is of no use, removed it
| set_exp_form.update(|val| { | ||
| *val += 1; | ||
| }); | ||
| close_drawer("create_exp_drawer"); |
There was a problem hiding this comment.
isn't this already being done by the handle_submit of the Experiment popup ?
| } | ||
| > | ||
|
|
||
| <EditorProvider> |
There was a problem hiding this comment.
@ShubhranshuSanjeev shouldn't this Provider be already present inside the Forms itself
ayushjain17
requested changes
Jan 30, 2025
yuvrajjsingh0
changed the title
yuvrajjsingh0
force-pushed
the
create-experiments-from-overrides
branch
2 times, most recently
from
733caf4 to
76e3430
Compare
|
@yuvrajjsingh0 Can you please attach a video for this? |
ayushjain17
reviewed
Jan 31, 2025
|
Video: Screen.Recording.2025-02-03.at.11.58.17.AM.mov |
| @@ -65,6 +69,14 @@ pub fn context_card( | |||
| <Show when=move || actions_supported> | |||
| <div class="h-fit text-right space-x-4"> | |||
| <Show when=move || !edit_unsupported> | |||
| <button | |||
There was a problem hiding this comment.
Could we adjust this button to match our theme colors?
There was a problem hiding this comment.
This is how it looks now! @mahatoankitkumar
yuvrajjsingh0
force-pushed
the
create-experiments-from-overrides
branch
from
95fd04c to
ee07907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Create Experiments From Overrides
Solution
Added create experiment popup to overrides