Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce strict version matches between jupyter-ai and jupyter-ai-magics #1263

Open
dlqqq opened this issue Feb 26, 2025 · 2 comments
Open

Enforce strict version matches between jupyter-ai and jupyter-ai-magics #1263

dlqqq opened this issue Feb 26, 2025 · 2 comments
Labels
enhancement New feature or request scope:releaser Issues concerning the release process scope:settings Issues concerning the Settings UI & backend in Jupyter AI

Comments

@dlqqq
Copy link
Member

dlqqq commented Feb 26, 2025

Problem

We currently lack an automated way to enforce a strict version match between jupyter-ai-magics and jupyter-ai when installed via pip. Fixes in jupyter-ai sometimes require downstream changes in jupyter-ai-magics, so users may need to update both packages to receive a bug fix. However, this is not done automatically by pip, which is really confusing to the end user.

This has caused several bugs:

Proposed Solution

  • Update bump-version.sh to somehow bump the version pin of jupyter-ai-magics.
  • Assert this in the release process somehow to prevent broken releases if this script gets broken.

Additional context

We do enforce this in our Conda Forge releases because that process is manual anyways. However, we should be doing this for PyPI releases too.

@dlqqq dlqqq added the enhancement New feature or request label Feb 26, 2025
@dlqqq dlqqq added this to Jupyter AI Feb 26, 2025
@dlqqq dlqqq moved this to Active in Jupyter AI Feb 26, 2025
@krassowski
Copy link
Member

krassowski commented Feb 26, 2025

I mentioned it before somewhere else, but jupyter-collaboration bumps the minimum required version in bump_version release scriptr: https://github.com/jupyterlab/jupyter-collaboration/blob/1c23b688ba22c1911d3ee93542e1da6e67f0514a/scripts/bump_version.py#L101-L124

but see discussion in jupyterlab/jupyter-collaboration#343

@krassowski
Copy link
Member

Ah yes, #745

@dlqqq dlqqq added scope:settings Issues concerning the Settings UI & backend in Jupyter AI scope:releaser Issues concerning the release process labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope:releaser Issues concerning the release process scope:settings Issues concerning the Settings UI & backend in Jupyter AI
Projects
Status: Active
Development

No branches or pull requests

2 participants