Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigManager for configuration options #436

Open
bollwyvl opened this issue Mar 26, 2015 · 1 comment
Open

Use ConfigManager for configuration options #436

bollwyvl opened this issue Mar 26, 2015 · 1 comment
Labels
type:Maintenance An enhancement to the architecture or maintenance of this project

Comments

@bollwyvl
Copy link
Contributor

As part of #428, it will likely become desirable to use the ConfigManager, a la IPython.html.notebookapp to configure nbviewer.

Specifically, this will make specifying and configuring modular, potentially un-bundled providers more tractable.

Generally, this will help in having a single place to document nbviewer-specific configuration options, and configuring upstream components like nbconvert, and make it easier for an in-house deployment to include specific information, such as #170, templates and other branding issues.

@bollwyvl bollwyvl added type:Enhancement A proposed extension to the behavior of the project type:Maintenance An enhancement to the architecture or maintenance of this project and removed type:Enhancement A proposed extension to the behavior of the project labels Sep 1, 2015
@krinsman
Copy link
Collaborator

krinsman commented Jul 5, 2019

Is this related to #840? Or is the type of configurability that JupyterHub uses (implemented in that PR) different from the notebook's ConfigManager? (I'm not familiar with that.)

It doesn't seem the same, but it also seems like ConfigManager requires a configurable class to work with, and that PR seems to be a first step towards making NBViewer configurable.

Several commits after that PR I was able to use such an nbviewer_config.py file to implement a "Notebook cloning extension" for NBViewer, so I think it works and is useful for the reasons you mentioned. Again, it's basically copied from what JupyterHub does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Maintenance An enhancement to the architecture or maintenance of this project
Projects
None yet
Development

No branches or pull requests

2 participants