Throw a validation error if the worksheet conversion fails #239
Conversation
Motivation:
- We are seeing a lot of errors in this worksheets process where keys
are not present that are needed, this pr adds a validation error when
this process cannot be completed because the key is missing.
|
I could add a test for this, however i am not sure how this relates to real life notebooks. I am happy to add one if someone can help me understand when this is and how it is used. Thank you. |
|
@MSeal I am curious if you know why these tests are failing. They work for me.... |
gwincr11
force-pushed
the
cg-validate-worksheets
branch
from
0a75534 to
b57d9be
Compare
|
Hey, @gwincr11 - sorry this got dropped on the floor years ago. Since it's been idling here for a while, I'm going to close it. |
|
Ok, we still see a few thousand of these errors a month. |
|
@gwincr11 sorry, where is this? I'm confused given what you wrote " i am not sure how this relates to real life notebooks". Can you share more about how v3 notebooks were created and why they are staying at v3 version, and maybe which keys end up missing? I'm not against merging a fix, I just assumed, perhaps wrongly, that the need for this fix has waned below the noise floor. Reopening, but let's remove the 3.5 compatibility, since that ship has sailed (looks like nbformat these days wants python 3.8) |
So these are errors we have seen on GitHub's notebook renderer. I do not know what is source is producing the notebooks, but can say we see them happen frequently. |
Motivation:
are not present that are needed, this pr adds a validation error when
this process cannot be completed because the key is missing.