Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identical content editor are collapsed #718

Closed
fcollonval opened this issue Oct 17, 2023 · 3 comments · Fixed by #736
Closed

Identical content editor are collapsed #718

fcollonval opened this issue Oct 17, 2023 · 3 comments · Fixed by #736

Comments

@fcollonval
Copy link
Collaborator

From jupyterlab-git example, single cell added or unchanged have their content collapse as identical. We should not collapse the content in such case.

image

There is also the case of the notebook metadata. But the issue is larger as the collapse widget title is wrong by announcing there is a change even when there is none. And in addition, it displays 4 editors even if there are no changes.

@fcollonval
Copy link
Collaborator Author

#719 solved the first part - the part about the notebook metadata still needs fixing.

@vidartf
Copy link
Collaborator

vidartf commented Nov 8, 2023

BTW: When doing a comparison between stable / RC, I notice the stable also lists metadata as having changes, even when there are none, so this might not be a regression (the metadata bit)? Rather, the full collapse just highlights the issue more clearly?

@fcollonval
Copy link
Collaborator Author

this might not be a regression (the metadata bit)?

Yes this is not a regression. But it will definitely be interesting for the user to know if the metadata have changed or not.

Rather, the full collapse just highlights the issue more clearly?

Yes indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants