feat: support nbagg matplotlib backend (WIP) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
feat_matplotlib_nbagg
branch
from
bfd2dca to
7fae1a6
Compare
maartenbreddels
force-pushed
the
feat_matplotlib_nbagg
branch
from
7fae1a6 to
55f7153
Compare
|
It now fails for the right reason, which is that the mime bundle only contains a div, while it should contain an image with the base64 encoded data. This is not implemented because I do not get the message containing the image data. |
|
@tacaswell @martinRenou |
|
Thanks for opening the WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve jupyter/nbconvert#1081 and would also make the old legacy nbagg backend work with nbconvert and voila (at least render it).
However, I cannot get it to work, the backend does not send me back the image, which then should be injected in the div.
Note: if you read this, consider using ipympl instead https://github.com/matplotlib/ipympl