CI: Display LightHouse stats in nicer way #692
Conversation
|
Here are the LightHouse Stats:
Currently, the comment is not being put up, since the GitHub Token is not accessible by integration (since the token is not available on forked repositories). Here are the logs: https://github.com/jupyter/jupyter.github.io/runs/5612667281?check_suite_focus=true |
| - name: LightHouse Statistic Comment | ||
| if: github.event_name == 'pull_request' | ||
| id: lighthouse_statistic_comment | ||
| uses: marocchino/[email protected] |
There was a problem hiding this comment.
Could you please use gh pr comment as it does not require installation of a third-party action?
|
Thank you, this looks like a good approach! As mentioned in code review, I would suggest to use Also, the following permissions may be needed: |
|
@HarshCasper and @krassowski, just doing some 🧹 cleaning: do you think this is still worth pursuing, or should we close it? |
|
My guess is that with actions being quite dynamic ecosystem we should reconsider the specific actions proposed. This PR is valuable but if it staying in unfinished state discourages other contributors let's close it. Also for now the priority would be fixing ci in the first place |
That makes sense, done in #749. I don't mind it being open if this can be used as a starting point by someone. I'll just convert it to draft since there are some unaddressed third-party-actions here. |
Fixes #582
This PR:
marocchino/[email protected]to put up the comment on the PRLightHouse Statistic Commentonly over a GitHub PR