-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub-hosted aarch64 runners #2202
base: main
Are you sure you want to change the base?
Conversation
There are some bugs in the ubuntu-24.04-arm image- some environment variables are incorrect: |
Beautiful!!! ❤️ 🎉 |
A job failed in this PR, but not in the main branch - a difference between these jobs is the test runner's python version, which is 3.10 (main branch) vs 3.13 (in this PR) --- Then in the x86_64 test from main branch and this PR, the Python test runner version is 3.12: Maybe the Python version in the aarch image is floating around a bit? Perhaps because the self-hosted aarch runners have a 3.x mapped to 3.10, while the new aarch runners have a 3.x mapped to 3.13, and the x86 runners have 3.x mapped to 3.12? I figure the fix could be to pin to 3.12 |
I pushed a commit to see if it helps to pin to 3.12! Edit: it seems so, or it was a coincidence - now it works at least! |
Thanks @consideRatio! |
|
Oh, hmmm, i wonder if it could be a timing thing - were the CI scripts started faster than docker daemon in arm64 compared to in x64. These things are messy to debug :/ |
I think we have quite a nice example of this happening! This only runs |
I added a |
Wow, it seems that even And we can't have this workaround in |
@@ -41,7 +41,7 @@ jobs: | |||
steps: | |||
# Image with CUDA needs extra disk space | |||
- name: Free disk space 🧹 | |||
if: contains(inputs.variant, 'cuda') && inputs.platform == 'x86_64' | |||
if: contains(inputs.variant, 'cuda') && runner.arch == 'X64' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use inputs.platform
when we want to name things.
runner.arch
is better in this case - it's standard when using GitHub runners
It seems that GitHub-hosted aarch64 runners aren't currently stable enough. So, let's wait for a while, I hope it will be better. |
The relevant discussions: https://github.com/orgs/community/discussions/148648 |
Describe your changes
Issue ticket if applicable
Fix: #2201
Fix: #2198
Checklist (especially for first-time contributors)