Skip to content

Commit 0b2af8d

Browse files
committed
Fix ENV syntax in Dockerfiles
1 parent 16d0f4d commit 0b2af8d

File tree

10 files changed

+28
-28
lines changed

10 files changed

+28
-28
lines changed

etc/docker/demo-base/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ ENV SHELL=/bin/bash \
2727
ENV HOME=/home/$NB_USER \
2828
PATH=$JAVA_HOME/bin:$ANACONDA_HOME/bin:$HADOOP_HOME/bin:$SPARK_HOME/bin:$PATH
2929

30-
ENV SPARK_VER $SPARK_VERSION
31-
ENV HADOOP_VER 3.3.1
30+
ENV SPARK_VER=$SPARK_VERSION
31+
ENV HADOOP_VER=3.3.1
3232

3333
# INSTALL / DOWNLOAD ALL NEEDED PACKAGES
3434
RUN dpkg --purge --force-depends ca-certificates-java \

etc/docker/enterprise-gateway/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ FROM $BASE_CONTAINER
44

55
ARG SPARK_VERSION
66

7-
ENV SPARK_VER $SPARK_VERSION
8-
ENV SPARK_HOME /opt/spark
7+
ENV SPARK_VER=$SPARK_VERSION
8+
ENV SPARK_HOME=/opt/spark
99

1010

1111
RUN mamba install --quiet --yes \
@@ -22,7 +22,7 @@ USER root
2222

2323
RUN apt update && apt install -yq curl openjdk-8-jdk
2424

25-
ENV JAVA_HOME /usr/lib/jvm/java
25+
ENV JAVA_HOME=/usr/lib/jvm/java
2626
RUN ln -s $(readlink -f /usr/bin/javac | sed "s:/bin/javac::") ${JAVA_HOME}
2727

2828
# Download and install Spark

etc/docker/kernel-image-puller/Dockerfile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ RUN apt-get update && apt-get install cri-tools
1717

1818
RUN echo $PATH
1919
# The following environment variables are supported - defaults provided. Override as needed.
20-
ENV KIP_GATEWAY_HOST http://localhost:8888
21-
ENV KIP_INTERVAL 300
22-
ENV KIP_LOG_LEVEL INFO
23-
ENV KIP_NUM_PULLERS 2
24-
ENV KIP_NUM_RETRIES 3
25-
ENV KIP_PULL_POLICY 'IfNotPresent'
20+
ENV KIP_GATEWAY_HOST=http://localhost:8888
21+
ENV KIP_INTERVAL=300
22+
ENV KIP_LOG_LEVEL=INFO
23+
ENV KIP_NUM_PULLERS=2
24+
ENV KIP_NUM_RETRIES=3
25+
ENV KIP_PULL_POLICY='IfNotPresent'
2626

2727
CMD [ "python", "./kernel_image_puller.py" ]

etc/docker/kernel-py/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ FROM $BASE_CONTAINER
55
ENV PATH=$PATH:$CONDA_DIR/bin
66

77
# Add debugger support
8-
RUN pip install --upgrade ipykernel
8+
RUN pip install --upgrade --no-cache-dir ipykernel
99

1010
RUN conda install --quiet --yes \
1111
cffi \
@@ -29,7 +29,7 @@ RUN chown jovyan:users /usr/local/bin/bootstrap-kernel.sh && \
2929

3030
USER jovyan
3131

32-
ENV KERNEL_LANGUAGE python
32+
ENV KERNEL_LANGUAGE=python
3333

3434
# Disble healthcheck inherited from notebook image
3535
HEALTHCHECK NONE

etc/docker/kernel-r/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ RUN chown jovyan:users /usr/local/bin/bootstrap-kernel.sh && \
2525

2626
USER jovyan
2727

28-
ENV KERNEL_LANGUAGE R
28+
ENV KERNEL_LANGUAGE=R
2929

3030
# Disble healthcheck inherited from notebook image
3131
HEALTHCHECK NONE

etc/docker/kernel-scala/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ RUN adduser --system -uid 1000 jovyan --ingroup users && \
1717
chown -R jovyan:users /usr/local/bin/kernel-launchers
1818

1919
USER jovyan
20-
ENV KERNEL_LANGUAGE scala
20+
ENV KERNEL_LANGUAGE=scala
2121
CMD /usr/local/bin/bootstrap-kernel.sh

etc/docker/kernel-spark-py/Dockerfile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ FROM $BASE_CONTAINER
77

88
ARG SPARK_VERSION
99

10-
ENV SPARK_VER $SPARK_VERSION
11-
ENV SPARK_HOME /opt/spark
12-
ENV KERNEL_LANGUAGE python
13-
ENV R_LIBS_USER $R_LIBS_USER:${SPARK_HOME}/R/lib
14-
ENV PATH $PATH:$SPARK_HOME/bin
10+
ENV SPARK_VER=$SPARK_VERSION
11+
ENV SPARK_HOME=/opt/spark
12+
ENV KERNEL_LANGUAGE=python
13+
ENV R_LIBS_USER=$R_LIBS_USER:${SPARK_HOME}/R/lib
14+
ENV PATH=$PATH:$SPARK_HOME/bin
1515

1616
USER root
1717

@@ -26,7 +26,7 @@ RUN dpkg --purge --force-depends ca-certificates-java \
2626
libssl-dev \
2727
&& rm -rf /var/lib/apt/lists/*
2828

29-
ENV JAVA_HOME /usr/lib/jvm/java
29+
ENV JAVA_HOME=/usr/lib/jvm/java
3030
RUN ln -s $(readlink -f /usr/bin/javac | sed "s:/bin/javac::") ${JAVA_HOME}
3131

3232
# Download and install Spark

etc/docker/kernel-spark-r/Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ ARG SPARK_VERSION
88

99
USER root
1010

11-
ENV SPARK_VER $SPARK_VERSION
12-
ENV SPARK_HOME /opt/spark
11+
ENV SPARK_VER=$SPARK_VERSION
12+
ENV SPARK_HOME=/opt/spark
1313
ENV KERNEL_LANGUAGE=R
14-
ENV R_LIBS_USER $R_LIBS_USER:${R_HOME}/library:${SPARK_HOME}/R/lib
15-
ENV PATH $PATH:$SPARK_HOME/bin
14+
ENV R_LIBS_USER=$R_LIBS_USER:${R_HOME}/library:${SPARK_HOME}/R/lib
15+
ENV PATH=$PATH:$SPARK_HOME/bin
1616

1717
RUN dpkg --purge --force-depends ca-certificates-java \
1818
&& apt-get update \
@@ -23,7 +23,7 @@ RUN dpkg --purge --force-depends ca-certificates-java \
2323
libssl-dev \
2424
&& rm -rf /var/lib/apt/lists/*
2525

26-
ENV JAVA_HOME /usr/lib/jvm/java
26+
ENV JAVA_HOME=/usr/lib/jvm/java
2727
RUN ln -s $(readlink -f /usr/bin/javac | sed "s:/bin/javac::") ${JAVA_HOME}
2828

2929
# Download and install Spark

etc/docker/kernel-tf-gpu-py/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ RUN adduser --system --uid 1000 --gid 100 jovyan && \
2727

2828

2929
USER jovyan
30-
ENV KERNEL_LANGUAGE python
30+
ENV KERNEL_LANGUAGE=python
3131
CMD /usr/local/bin/bootstrap-kernel.sh

etc/docker/kernel-tf-py/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ ARG BASE_CONTAINER=jupyter/tensorflow-notebook:2023-10-20
44

55
FROM $BASE_CONTAINER
66

7-
ENV KERNEL_LANGUAGE python
7+
ENV KERNEL_LANGUAGE=python
88

99
ADD jupyter_enterprise_gateway_kernel_image_files*.tar.gz /usr/local/bin/
1010

0 commit comments

Comments
 (0)