Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport JAVA_23 and JAVA_24 JRE constants to 5.10.x #3918

Closed
snicoll opened this issue Aug 7, 2024 · 9 comments
Closed

Backport JAVA_23 and JAVA_24 JRE constants to 5.10.x #3918

snicoll opened this issue Aug 7, 2024 · 9 comments

Comments

@snicoll
Copy link

snicoll commented Aug 7, 2024

Please backport for testing Java 23 to 5.10.x as Java 23 is around the corner and the only option AFAICS is to use OTHER.

@marcphilipp
Copy link
Member

The plan is to release 5.11 next week. Therefore, no additional 5.10.x release is scheduled.

@marcphilipp marcphilipp closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@sbrannen sbrannen changed the title Backport JRE.JAVA_23 to 5.1.0.x Backport JRE.JAVA_23 to 5.10.x Aug 8, 2024
snicoll added a commit to spring-projects/spring-boot that referenced this issue Aug 8, 2024
This commit uses JRE#OTHER as JUnit does not have support for Java 23
yet, see junit-team/junit5#3918

Closes gh-41710
@snicoll
Copy link
Author

snicoll commented Aug 19, 2024

@marcphilipp thanks for the reply. While I understand the policy I am wondering what the plan is for projects that have a maintenance policy and need to pick up/build against recent Java versions?

In my case, Spring Boot is in maintenance mode and can't upgrade to JUnit 5.11. However, it will support up to Java 25.

Is there an escape hatch here? Or do we have to create our own condition?

@sbrannen
Copy link
Member

While I understand the policy I am wondering what the plan is for projects that have a maintenance policy and need to pick up/build against recent Java versions?

That's a valid question. We discussed it briefly within the team and decided to leave things as-is for the time being.

Is there an escape hatch here?

No, there is currently no escape hatch for JDK versions released after a particular JUnit Jupiter branch is no longer officially supported.

However, I'm going to reopen this issue so that we can discuss the topic again within the team.

@sbrannen sbrannen added this to the 5.11.1 milestone Aug 20, 2024
@sbrannen sbrannen changed the title Backport JRE.JAVA_23 to 5.10.x Backport JAVA_23 and JAVA_24 JRE constants to 5.10.x Sep 2, 2024
@marcphilipp
Copy link
Member

@snicoll I think the escape hatch would be to document how to use a later version of JUnit with the Spring Boot version that's in maintenance mode, should users want to upgrade. We already have a section for that in our User Guide that Spring Boot's docs could link to. WDYT?

@snicoll
Copy link
Author

snicoll commented Sep 12, 2024

I've raised this issue for our own needs. And for everyone who has a maintenance policy like ours.

One could argue the current arrangement is quite artificial as all that's needed is a new enum value and everything would work from a JUnit perspective.

@sbrannen
Copy link
Member

One could argue the current arrangement is quite artificial as all that's needed is a new enum value and everything would work from a JUnit perspective.

We hope to address that in #3931.

@marcphilipp
Copy link
Member

I've raised this issue for our own needs.

@snicoll You mean for your own tests, right? Could you not use a different version of JUnit for the test sources than for the main sources?

@marcphilipp
Copy link
Member

Team decision: Backport the enum constants to 5.10.x and 5.11.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants