-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport JAVA_23
and JAVA_24
JRE
constants to 5.10.x
#3918
Comments
The plan is to release 5.11 next week. Therefore, no additional 5.10.x release is scheduled. |
JRE.JAVA_23
to 5.10.x
This commit uses JRE#OTHER as JUnit does not have support for Java 23 yet, see junit-team/junit5#3918 Closes gh-41710
@marcphilipp thanks for the reply. While I understand the policy I am wondering what the plan is for projects that have a maintenance policy and need to pick up/build against recent Java versions? In my case, Spring Boot is in maintenance mode and can't upgrade to JUnit 5.11. However, it will support up to Java 25. Is there an escape hatch here? Or do we have to create our own condition? |
That's a valid question. We discussed it briefly within the team and decided to leave things as-is for the time being.
No, there is currently no escape hatch for JDK versions released after a particular JUnit Jupiter branch is no longer officially supported. However, I'm going to reopen this issue so that we can discuss the topic again within the team. |
JRE.JAVA_23
to 5.10.x
JAVA_23
and JAVA_24
JRE
constants to 5.10.x
@snicoll I think the escape hatch would be to document how to use a later version of JUnit with the Spring Boot version that's in maintenance mode, should users want to upgrade. We already have a section for that in our User Guide that Spring Boot's docs could link to. WDYT? |
I've raised this issue for our own needs. And for everyone who has a maintenance policy like ours. One could argue the current arrangement is quite artificial as all that's needed is a new enum value and everything would work from a JUnit perspective. |
We hope to address that in #3931. |
@snicoll You mean for your own tests, right? Could you not use a different version of JUnit for the test sources than for the main sources? |
Team decision: Backport the enum constants to 5.10.x and 5.11.x. |
Please backport for testing Java 23 to
5.10.x
as Java 23 is around the corner and the only option AFAICS is to useOTHER
.The text was updated successfully, but these errors were encountered: