Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert quadratic to affine even when there is no parameters #166

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 21, 2025

I am playing around using POI with SumOfSquares and was hitting an error for f - g * p if p is a parameter and g has less monomials than f. Indeed, this will create scalar quadratic constraint with no quadratic term and with no parameter which currently fails.
This PR should fix it

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (42d5d6b) to head (8f973c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   95.39%   95.80%   +0.41%     
==========================================
  Files           5        5              
  Lines        1085     1097      +12     
==========================================
+ Hits         1035     1051      +16     
+ Misses         50       46       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat merged commit 58c316e into master Jan 22, 2025
8 checks passed
@blegat blegat deleted the bl/quad_to_affine branch January 22, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants