Version 1.1.3 input field match fixes.

judgej · judgej · commit 550221a88e7c · 2014-02-27T02:06:34.000Z
diff --git a/README.md b/README.md
@@ -97,6 +97,7 @@ http://plugins.jquery.com/jquery-maxsubmit/
 
 ## History
 
+1.1.3 Fixed count of HTML5 input elements  
 1.1.2 Updated metadata for plugins.jquery.com  
 1.1.1 Fixed syntax error messaing with Chrome  
 1.1.0 Issue #2 reported by @Bubbendorf Update to demo to demonstrate fixes.  
diff --git a/index.php b/index.php
@@ -1,6 +1,7 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
-<html>
+<!DOCTYPE html>
+<html lang="en">
 <head>
+    <meta charset="UTF-8">
     <title>jquery-maxsubmit plugin demo</title>
     <meta name="Generator" content="EditPlus">
     <meta name="Author" content="Jason Judge">
@@ -44,6 +45,8 @@
     $input = array(
         'text1' => 'Text 1',
         'text2' => 'Text 2',
+        'text3' => '',
+        'text4' => '',
         'textarea1' => "A nice\nstory.",
         'checkbox1' => 'on',
         'checkbox2' => '',
@@ -126,12 +129,27 @@ function getFormSubmissionLimit($default = false)
 
         <p>
             <input type="text" name="text1" value="<?php echo $input['text1']; ?>" />
-            <span class="text_label" title="Click to toggle toggle the enabled state">(counts as one parameter)</span>
+            <span class="text_label" title="Click to toggle toggle the enabled state">(text counts as one parameter)</span>
         </p>
 
         <p>
             <input type="text" name="text2" value="<?php echo $input['text2']; ?>" />
-            <span class="text_label" title="Click to toggle toggle the enabled state">(counts as one parameter)</span>
+            <span class="text_label" title="Click to toggle toggle the enabled state">(text counts as one parameter)</span>
+        </p>
+
+        <p>
+            <input type="email" name="text3" value="<?php echo $input['text3']; ?>" />
+            <span class="text_label" title="Click to toggle toggle the enabled state">(email counts as one parameter)</span>
+        </p>
+
+        <p>
+            <input type="date" name="text4" value="<?php echo $input['text4']; ?>" />
+            <span class="text_label" title="Click to toggle toggle the enabled state">(date counts as one parameter)</span>
+        </p>
+
+        <p>
+            <input type="hidden" value="hidden" />[hidden]
+            <span class="text_label" title="Click to toggle toggle the enabled state">(hidden field counts as one parameter)</span>
         </p>
 
         <p>
diff --git a/jquery-maxsubmit.jquery.json b/jquery-maxsubmit.jquery.json
@@ -7,7 +7,7 @@
 		"maxinputvars",
 		"suhosin"
 	],
-	"version": "1.1.2",
+	"version": "1.1.3",
 	"author": {
 		"name": "Jason Judge",
 		"url": "https://github.com/judgej"
diff --git a/jquery.maxsubmit.js b/jquery.maxsubmit.js
@@ -2,7 +2,7 @@
  * Copyright 2013-2014 Academe Computing Ltd
  * Released under the MIT license
  * Author: Jason Judge <jason@academe.co.uk>
- * Version: 1.1.2
+ * Version: 1.1.3
  */
 /**
  * jquery.maxsubmit.js
@@ -61,8 +61,19 @@
 					// We have a form, so count up the form items that will be
 					// submitted to the server.
 
-					// Text fields and submit buttons will all post one parameter.
-					var form_count = $('input:text:enabled, input:submit:enabled, input:password:enabled, textarea:enabled', this).length;
+					// textarea fields count as one submitted field each.
+					var form_count = $('textarea:enabled', this).length;
+
+					// Input fields of all types except checkboxes and radio buttons will
+					// all post one parameter.
+					// reset inputs are not submitted to the server and files are handled
+					// separately.
+					form_count += $('input:enabled', this)
+						.not("[type='checkbox']")
+						.not("[type='radio']")
+						.not("[type='file']")
+						.not("[type='reset']")
+						.length;
 
 					// Checkboxes will post only if checked.
 					$('input:checkbox:enabled', this).each(function() {
@@ -81,7 +92,8 @@
 						if (select !== null) form_count += select.length;
 					});
 
-					// Each radio button group will post one parameter.
+					// Each radio button group will post one parameter, regardless of how many
+					// radio buttons a group contains.
 					// Count the radio groups
 					var rgroups = [];
 					$('input:enabled:radio').each(function(index, el) {
