Not showing a validation message for conditional questions with the recent ver. of schema-form.js

[warmy1004]

Hello all,

I have an issue to show a validation message for conditional questions. Just in case, I am using the recent version of schema-form.js which is updated by Angular Schema form team 6 months ago. The version number of this schema-form.js in their package.json is 0.8.12.

Here is my example: https://plnkr.co/edit/GpmbaMPZmtgofOdV0Fye?p=preview
How to reproduce the issue in my example:
(1) select 'YES' for showing some conditional questions from the first question
The first question is "Do you want to see the 2nd questions?".
(2) just click 'Validate' button to validate the entire form.
(3) You can see some css changes (color change to red), but you can't see any error message (sf-message) under each field, which should be 'Required'.

However, if you click 'validate' button for the 1st question without any selected value(Yes or No), you can see a proper error message (Required) because this is not the conditional questions.
how to see this:
(1) Just click 'validate' button from the first question without any selected value.
(2) Then, you can see "Required" red error message under the radio buttons.

Do you have any idea for this?
Thank you,

[warmy1004]

Previously, I was using an old version of schema-form.js. So, I updated the proper recent schema-form.js which I tested.

[Anthropic]

@warmy1004 was the result the same with the latest version? Like when you say you updated to the recent version is the plunker using 0.8.12?

[warmy1004]

@Anthropic In the above plunker, I used v.0.8.12 which is the recent version as far as I know. And, with the previous version of schema-form instead of 0.8.12, the result was different. FYI, the issue with the previous version was the shown error message for radios-inline question didn't disappear when I selected 'yes' first. But, it worked fine if I selected 'No' first.
To help your understanding, here is the plunker link: https://plnkr.co/edit/wi44coI5gNc6AdpxdYJh?p=preview
The only difference between the two plunker examples I updated is schema-form.js.
Unfortunately, I don't know what the version of the previous one exactly is.

[Anthropic]

@warmy1004 thank you so much for the plunkers they are a great help, I'm not sure if this will be looked at before or after the separation of the core library is completed, but I will keep it on the radar to be looked into asap.

[Anthropic]

I'm about to release 0.8.13, curious to see if that has any affect.

[warmy1004]

@Anthropic Okay. Thank you. BTW, can you let me know when the next release 0.8.13 will come?

[Anthropic]

@warmy1004 I'm hoping for today or tomorrow, it's already in the master branch, I'm just about to tag it and then get David to push to npm, but in theory it should be on bower as soon as it is tagged.

[warmy1004]

@Anthropic Just fyi, I downloaded 0.8.13 version and tested it. But, my issue is not solved as we expected. Thank you.

[warmy1004]

Hello, I want to share what I found for solving this issue.
In 0.8.12 version of Schema-from, the conditional questions' missing error message text issue is caused by validation when the conditional questions are loaded. That is, when the conditional questions display, schema-form validates the forms, and those forms are set to have 'tv4-302' (required) error even though they are still pristine. So, when the actual 'tv4-302' validation happens, ngModel.$error for the conditional questions are not changed and the below $watchCollection
scope.$watchCollection('ngModel.$error', function() {
update(!!scope.ngModel);
});
can't be run for calling setMessage(). So, I changed one line inside schemaValidate directive's validate() from if (!result.valid) { to if (!result.valid && !ngModel.$pristine) {. With this change, the conditional question issue looks like fixed.

FYI, v 0.8.13 of schema-form with this change also works fine for conditional question's validation error message.

[Anthropic]

@warmy1004 that's great thanks, can you make a PR or let me know which file and line in the src it is?