Skip to content

Commit 460435c

Browse files
authored
Merge pull request #8 from f3ath/development
PSR-12
2 parents 4f1a7ef + 3c8e445 commit 460435c

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

.travis.yml

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
language: php
22
php:
3-
- '7.0'
43
- '7.1'
5-
- hhvm
64
- nightly
75

86
before_script:

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ $author = Relationship::fromLinkage(
3939
$author->setLink('self', '/articles/1/relationships/author');
4040
$author->setLink('related', '/articles/1/author');
4141

42-
$articles = new Resource('articles', '1');
42+
$articles = new ResourceObject('articles', '1');
4343
$articles->setRelationship('author', $author);
4444
$articles->setAttribute('title', 'Rails is Omakase');
4545

src/Document/Resource/Resource.php renamed to src/Document/Resource/ResourceObject.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
use JsonApiPhp\JsonApi\Document\Resource\Relationship\Relationship;
99
use JsonApiPhp\JsonApi\HasLinksAndMeta;
1010

11-
final class Resource implements PrimaryData, PrimaryDataItem
11+
final class ResourceObject implements PrimaryData, PrimaryDataItem
1212
{
1313
use HasLinksAndMeta;
1414

test/Document/Resource/ResourceTest.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
namespace JsonApiPhp\JsonApi\Test\Document\Resource;
55

66
use JsonApiPhp\JsonApi\Document\Resource\Relationship\Relationship;
7-
use JsonApiPhp\JsonApi\Document\Resource\Resource;
7+
use JsonApiPhp\JsonApi\Document\Resource\ResourceObject;
88
use JsonApiPhp\JsonApi\Document\Resource\ResourceId;
99
use JsonApiPhp\JsonApi\Test\HasAssertEqualsAsJson;
1010
use PHPUnit\Framework\TestCase;
@@ -71,7 +71,7 @@ public function resourceProvider()
7171
],
7272
],
7373
(function () {
74-
$resource = new Resource('books', '42abc');
74+
$resource = new ResourceObject('books', '42abc');
7575
$resource->setMeta('foo', 'bar');
7676
$resource->setAttribute('attr', 'val');
7777
$resource->setLink('self', 'http://localhost');
@@ -90,7 +90,7 @@ public function resourceProvider()
9090
*/
9191
public function testAttributeCanNotHaveReservedNames(string $name)
9292
{
93-
$r = new Resource('books', 'abc');
93+
$r = new ResourceObject('books', 'abc');
9494
$r->setAttribute($name, 1);
9595
}
9696

@@ -108,7 +108,7 @@ public function invalidAttributeNames(): array
108108
*/
109109
public function testCanNotSetRelationshipIfAttributeExists()
110110
{
111-
$res = new Resource('books', '1');
111+
$res = new ResourceObject('books', '1');
112112
$res->setAttribute('foo', 'bar');
113113
$res->setRelationship('foo', Relationship::fromMeta(['a' => 'b']));
114114
}
@@ -119,7 +119,7 @@ public function testCanNotSetRelationshipIfAttributeExists()
119119
*/
120120
public function testCanNotSetAttributeIfRelationshipExists()
121121
{
122-
$res = new Resource('books', '1');
122+
$res = new ResourceObject('books', '1');
123123
$res->setRelationship('foo', Relationship::fromMeta(['a' => 'b']));
124124
$res->setAttribute('foo', 'bar');
125125
}

test/IntegrationTest.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
<?php
22
declare(strict_types=1);
3+
34
namespace JsonApiPhp\JsonApi\Test;
45

56
use JsonApiPhp\JsonApi\Document\Document;
67
use JsonApiPhp\JsonApi\Document\Resource\Relationship\Linkage;
78
use JsonApiPhp\JsonApi\Document\Resource\Relationship\Relationship;
8-
use JsonApiPhp\JsonApi\Document\Resource\Resource;
9+
use JsonApiPhp\JsonApi\Document\Resource\ResourceObject;
910
use JsonApiPhp\JsonApi\Document\Resource\ResourceId;
1011
use PHPUnit\Framework\TestCase;
1112

@@ -37,7 +38,7 @@ public function testFromTheReadmeFile()
3738
}
3839
JSON;
3940

40-
$articles = new Resource('articles', '1');
41+
$articles = new ResourceObject('articles', '1');
4142
$author = Relationship::fromLinkage(
4243
Linkage::fromSingleResourceId(
4344
new ResourceId('people', '9')

0 commit comments

Comments
 (0)