Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.0 instead of 1.0 from JsonApiDotNetCore.Annotations #1592

Open
bkoelman opened this issue Jul 12, 2024 · 1 comment
Open
Labels
breaking-change dependencies Pull requests that update a dependency file

Comments

@bkoelman
Copy link
Member

bkoelman commented Jul 12, 2024

See the recommendation at https://github.com/dotnet/designs/blob/main/accepted/2024/net-standard-recommendation.md.

Building for netstandard1.0 using the .NET 9 SDK produces the following warning:

warning NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details.

Although this is technically a breaking change, I don't expect this change to affect users in practice.

@bkoelman bkoelman added breaking-change dependencies Pull requests that update a dependency file labels Jul 12, 2024
@bkoelman
Copy link
Member Author

This warning is currently suppressed at:

<NoWarn>$(NoWarn);NETSDK1215</NoWarn>

@bkoelman bkoelman changed the title Replace netstandard1.0 with netstandard2.0 in JsonApiDotNetCore.Annotations Target netstandard2.0 instead of 1.0 from JsonApiDotNetCore.Annotations Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change dependencies Pull requests that update a dependency file
Development

No branches or pull requests

1 participant