forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathexpanded_date_range.rb
86 lines (72 loc) · 2.65 KB
/
expanded_date_range.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop checks for expanded date range. It only compatible `..` range is targeted.
# Incompatible `...` range is ignored.
#
# @example
# # bad
# date.beginning_of_day..date.end_of_day
# date.beginning_of_week..date.end_of_week
# date.beginning_of_month..date.end_of_month
# date.beginning_of_quarter..date.end_of_quarter
# date.beginning_of_year..date.end_of_year
#
# # good
# date.all_day
# date.all_week
# date.all_month
# date.all_quarter
# date.all_year
#
class ExpandedDateRange < Base
extend AutoCorrector
extend TargetRailsVersion
MSG = 'Use `%<preferred_method>s` instead.'
minimum_target_rails_version 5.1
def_node_matcher :expanded_date_range, <<~PATTERN
(irange
(send
$_ {:beginning_of_day :beginning_of_week :beginning_of_month :beginning_of_quarter :beginning_of_year})
(send
$_ {:end_of_day :end_of_week :end_of_month :end_of_quarter :end_of_year}))
PATTERN
PREFERRED_METHODS = {
beginning_of_day: 'all_day',
beginning_of_week: 'all_week',
beginning_of_month: 'all_month',
beginning_of_quarter: 'all_quarter',
beginning_of_year: 'all_year'
}.freeze
MAPPED_DATE_RANGE_METHODS = {
beginning_of_day: :end_of_day,
beginning_of_week: :end_of_week,
beginning_of_month: :end_of_month,
beginning_of_quarter: :end_of_quarter,
beginning_of_year: :end_of_year
}.freeze
def on_irange(node)
return unless expanded_date_range(node)
begin_node = node.begin
end_node = node.end
return unless same_receiver?(begin_node, end_node)
beginning_method = begin_node.method_name
end_method = end_node.method_name
return unless use_mapped_methods?(beginning_method, end_method)
preferred_method = "#{begin_node.receiver.source}.#{PREFERRED_METHODS[beginning_method]}"
add_offense(node, message: format(MSG, preferred_method: preferred_method)) do |corrector|
corrector.replace(node, preferred_method)
end
end
private
def same_receiver?(begin_node, end_node)
begin_node.receiver.source == end_node.receiver.source
end
def use_mapped_methods?(beginning_method, end_method)
MAPPED_DATE_RANGE_METHODS[beginning_method] == end_method
end
end
end
end
end