test: add tests for invalid numeric types

Author: cdoublev

lib/parsers.test.js

@@ -3,16 +3,23 @@
 const parsers = require('./parsers');
 
 describe('parseInteger', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1px', '1%', '#1', '1.1', '.1', '1e-1', 'calc(1 / 2)'];
+    invalid.forEach(input => expect(parsers.parseInteger(input)).toBeUndefined());
+  });
   it('parses integer with exponent', () => {
     expect(parsers.parseInteger('1e1')).toBe('10');
     expect(parsers.parseInteger('1e+1')).toBe('10');
   });
   it('works with calc', () => {
     expect(parsers.parseInteger('calc(1 + 1)')).toBe('2');
   });
-  it.todo('more tests');
 });
 describe('parseNumber', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1px', '1%', '#1', 'calc(1 * 1px)'];
+    invalid.forEach(input => expect(parsers.parseNumber(input)).toBeUndefined());
+  });
   it('parses number with exponent', () => {
     expect(parsers.parseNumber('1e1')).toBe('10');
     expect(parsers.parseNumber('1e+1')).toBe('10');
@@ -27,9 +34,12 @@ describe('parseNumber', () => {
   it('works with calc', () => {
     expect(parsers.parseNumber('calc(1.5 + 1.5)')).toBe('3');
   });
-  it.todo('more tests');
 });
 describe('parseLength', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1', 'px', '1%', '#1px', '1pxx', 'calc(1 * 1%)'];
+    invalid.forEach(input => expect(parsers.parseLength(input)).toBeUndefined());
+  });
   it('parses 0 to 0px', () => {
     expect(parsers.parseLength('0')).toBe('0px');
   });
@@ -59,9 +69,12 @@ describe('parseLength', () => {
   it('works with calc', () => {
     expect(parsers.parseLength('calc(1px + 1px)')).toBe('calc(2px)');
   });
-  it.todo('more tests');
 });
 describe('parsePercent', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1%%', '1px%', '#1%', 'calc(1 * 1px)'];
+    invalid.forEach(input => expect(parsers.parsePercent(input)).toBeUndefined());
+  });
   it('parses percent with exponent', () => {
     expect(parsers.parsePercent('1e1%')).toBe('10%');
     expect(parsers.parsePercent('1e+1%')).toBe('10%');
@@ -76,12 +89,15 @@ describe('parsePercent', () => {
   it('works with calc', () => {
     expect(parsers.parsePercent('calc(1% + 1%)')).toBe('calc(2%)');
   });
-  it.todo('more tests');
 });
 describe('parseMeasurement', () => {
   it.todo('test');
 });
 describe('parseAngle', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1', '1degg', 'a1deg', 'deg', 'calc(1 * 1px)'];
+    invalid.forEach(input => expect(parsers.parseAngle(input)).toBeUndefined());
+  });
   it('parses 0 to 0deg', () => {
     expect(parsers.parseAngle('0')).toBe('0deg');
   });
@@ -110,9 +126,12 @@ describe('parseAngle', () => {
   it('works with calc', () => {
     expect(parsers.parseAngle('calc(1deg + 1deg)')).toBe('calc(2deg)');
   });
-  it.todo('more tests');
 });
 describe('parseTime', () => {
+  it('returns undefined for invalid values', () => {
+    const invalid = ['string', '1', '1ss', 'a1s', 's', 'calc(1 * 1px)'];
+    invalid.forEach(input => expect(parsers.parseTime(input)).toBeUndefined());
+  });
   it('parses time with exponent', () => {
     expect(parsers.parseTime('1e1s')).toBe('10s');
     expect(parsers.parseTime('1e+1s')).toBe('10s');
@@ -133,7 +152,6 @@ describe('parseTime', () => {
   it('works with calc', () => {
     expect(parsers.parseTime('calc(1s + 1s)')).toBe('calc(2s)');
   });
-  it.todo('more tests');
 });
 describe('parseCalc', () => {
   it.skip('return undefined with 0 and <dimension-percentage> as operands', () => {