Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable elements of package file browser & copy dropdown aren't accessible #685

Open
ravindUwU opened this issue Sep 20, 2024 · 2 comments

Comments

@ravindUwU
Copy link

ravindUwU commented Sep 20, 2024

Screenshot of the package file browser taken with tabbing order annotations enabled in the "Accessibility" tab of Firefox devtools:


We should probably add:

  1. The breakcrumb, parent directory, directory and show more links aren't keyboard accessible.
    • These are already <a>s, but without hrefs. Specify tabindex="0" explicitly.
  2. The copy to clipboard buttons (and therefore the copy dropdown) aren't keyboard accessbile.
    • Button role for the trigger.
    • Listbox roles and popup attributes for the menu & and its items.
    • Key press handlers for the menu items ( & to switch items, Esc to close the menu).
  3. The add to collection switch isn't keyboard accessible.
@ravindUwU ravindUwU changed the title Clickable elements of package file browser aren't accessible Clickable elements of package file browser & copy dropdown aren't accessible Sep 20, 2024
@MartinKolarik
Copy link
Member

This would be a nice improvement for sure, would you like to send a PR?

@ravindUwU
Copy link
Author

I'm unable to work on this in the short term because of some other priorities 😓, so if anyone else wants to grab this issue, please feel free to go ahead! 🍀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants