Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropbox setting DROPBOX_OAUTH2_TOKEN is being ignored #1445

Closed
patroqueeet opened this issue Aug 30, 2024 · 0 comments · Fixed by #1452
Closed

Dropbox setting DROPBOX_OAUTH2_TOKEN is being ignored #1445

patroqueeet opened this issue Aug 30, 2024 · 0 comments · Fixed by #1452

Comments

@patroqueeet
Copy link

with this change

bdb0038#diff-ae567fb35986cceee2f0399f7be300078047a13c07299ef415971c7e2f786bbeR75

the default oauth2_access_token is set to None- which will override the value loaded from settings here https://github.com/jschneier/django-storages/blob/1.14.4/storages/base.py#L21 and set it back to None.

Expected: override settings through kwargs only if they are not None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dropbox] Fix setting oauth2 access token via env var jschneier/django-storages
1 participant
@patroqueeet