Skip to content

Commit e8d1586

Browse files
committed
Stable Version 1.0.0-alpha.3.
1 parent 204d5c5 commit e8d1586

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
##### 1.0.0-alpha.3 - 23 November 2014
2+
3+
###### Backwards compatible bug fixes
4+
- Fixed the "in", "notIn", "|in", and "|notIn" operators
5+
16
##### 1.0.0-alpha.2 - 23 November 2014
27

38
Upgraded dependencies

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "js-data-rethinkdb",
33
"description": "RethinkDB adapter for js-data.",
4-
"version": "1.0.0-alpha.2",
4+
"version": "1.0.0-alpha.3",
55
"homepage": "http://www.js-data.io/docs/dsrethinkdbadapter",
66
"repository": {
77
"type": "git",

src/index.js

+16-16
Original file line numberDiff line numberDiff line change
@@ -63,37 +63,37 @@ function filterQuery(resourceConfig, params, options) {
6363
}
6464
forOwn(criteria, function (v, op) {
6565
if (op === '==' || op === '===') {
66-
subQuery = subQuery ? subQuery.and(r.row(field).eq(v)) : r.row(field).eq(v);
66+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).eq(v)) : r.row(field).default(null).eq(v);
6767
} else if (op === '!=' || op === '!==') {
68-
subQuery = subQuery ? subQuery.and(r.row(field).ne(v)) : r.row(field).ne(v);
68+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).ne(v)) : r.row(field).default(null).ne(v);
6969
} else if (op === '>') {
70-
subQuery = subQuery ? subQuery.and(r.row(field).gt(v)) : r.row(field).gt(v);
70+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).gt(v)) : r.row(field).default(null).gt(v);
7171
} else if (op === '>=') {
72-
subQuery = subQuery ? subQuery.and(r.row(field).ge(v)) : r.row(field).ge(v);
72+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).ge(v)) : r.row(field).default(null).ge(v);
7373
} else if (op === '<') {
74-
subQuery = subQuery ? subQuery.and(r.row(field).lt(v)) : r.row(field).lt(v);
74+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).lt(v)) : r.row(field).default(null).lt(v);
7575
} else if (op === '<=') {
76-
subQuery = subQuery ? subQuery.and(r.row(field).le(v)) : r.row(field).le(v);
76+
subQuery = subQuery ? subQuery.and(r.row(field).default(null).le(v)) : r.row(field).default(null).le(v);
7777
} else if (op === 'in') {
78-
subQuery = subQuery ? subQuery.and(r.row(field).contains(v)) : r.row(field).contains(v);
78+
subQuery = subQuery ? subQuery.and(r.expr(v).default(r.expr([])).contains(r.row(field).default(null))) : r.expr(v).default(r.expr([])).contains(r.row(field).default(null));
7979
} else if (op === 'notIn') {
80-
subQuery = subQuery ? subQuery.and(r.row(field).contains(v).not()) : r.row(field).contains(v).not();
80+
subQuery = subQuery ? subQuery.and(r.expr(v).default(r.expr([])).contains(r.row(field).default(null)).not()) : r.expr(v).default(r.expr([])).contains(r.row(field).default(null)).not();
8181
} else if (op === '|==' || op === '|===') {
82-
subQuery = subQuery ? subQuery.or(r.row(field).eq(v)) : r.row(field).eq(v);
82+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).eq(v)) : r.row(field).default(null).eq(v);
8383
} else if (op === '|!=' || op === '|!==') {
84-
subQuery = subQuery ? subQuery.or(r.row(field).ne(v)) : r.row(field).ne(v);
84+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).ne(v)) : r.row(field).default(null).ne(v);
8585
} else if (op === '|>') {
86-
subQuery = subQuery ? subQuery.or(r.row(field).gt(v)) : r.row(field).gt(v);
86+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).gt(v)) : r.row(field).default(null).gt(v);
8787
} else if (op === '|>=') {
88-
subQuery = subQuery ? subQuery.or(r.row(field).ge(v)) : r.row(field).ge(v);
88+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).ge(v)) : r.row(field).default(null).ge(v);
8989
} else if (op === '|<') {
90-
subQuery = subQuery ? subQuery.or(r.row(field).lt(v)) : r.row(field).lt(v);
90+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).lt(v)) : r.row(field).default(null).lt(v);
9191
} else if (op === '|<=') {
92-
subQuery = subQuery ? subQuery.or(r.row(field).le(v)) : r.row(field).le(v);
92+
subQuery = subQuery ? subQuery.or(r.row(field).default(null).le(v)) : r.row(field).default(null).le(v);
9393
} else if (op === '|in') {
94-
subQuery = subQuery ? subQuery.or(r.row(field).contains(v)) : r.row(field).contains(v);
94+
subQuery = subQuery ? subQuery.or(r.expr(v).default(r.expr([])).contains(r.row(field).default(null))) : r.expr(v).default(r.expr([])).contains(r.row(field).default(null));
9595
} else if (op === '|notIn') {
96-
subQuery = subQuery ? subQuery.or(r.row(field).contains(v).not()) : r.row(field).contains(v).not();
96+
subQuery = subQuery ? subQuery.or(r.expr(v).default(r.expr([])).contains(r.row(field).default(null)).not()) : r.expr(v).default(r.expr([])).contains(r.row(field).default(null)).not();
9797
}
9898
});
9999
});

0 commit comments

Comments
 (0)