Skip to content

Commit ff1919f

Browse files
committed
Stable Version 1.0.1.
Fixes #4
1 parent 534ee73 commit ff1919f

20 files changed

+104
-97
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
##### 1.0.1 - 25 February 2015
2+
3+
###### Backwards compatible bug fixes
4+
- #7 - Does not properly throw error in find() (like other adapters) when the item cannot be found
5+
16
##### 1.0.0 - 03 February 2015
27

38
Stable Version 1.0.0

Gruntfile.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ module.exports = function (grunt) {
3535
uglify: {
3636
main: {
3737
options: {
38+
sourceMap: true,
39+
sourceMapName: 'dist/js-data-firebase.min.map',
3840
banner: '/**\n' +
3941
'* @author Jason Dobry <[email protected]>\n' +
4042
'* @file js-data-firebase.min.js\n' +

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Firebase adapter for [js-data](http://www.js-data.io/).
1515
| Branch | Master |
1616
| ------ | ------ |
1717
| Bower | [![Bower version](https://badge.fury.io/bo/js-data-firebase.png)](http://badge.fury.io/bo/js-data-firebase) |
18-
| NPM | [![NPM version](https://badge.fury.io/js/js-data-firebase.png)](http://badge.fury.io/js/js-data-firebase) |
18+
| NPM | [![NPM](https://nodei.co/npm/js-data-firebase.png?downloads=true&stars=true)](https://nodei.co/npm/js-data-firebase/) |
1919
| Build Status | [![Build Status](https://travis-ci.org/js-data/js-data-firebase.png?branch=master)](https://travis-ci.org/js-data/js-data-firebase) |
2020
| Code Climate | [![Code Climate](https://codeclimate.com/github/js-data/js-data-firebase.png)](https://codeclimate.com/github/js-data/js-data-firebase) |
2121
| Dependency Status | [![Dependency Status](https://gemnasium.com/js-data/js-data-firebase.png)](https://gemnasium.com/js-data/js-data-firebase) |

bower.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"karma.start.js"
3030
],
3131
"dependencies": {
32-
"js-data": ">=1.0.0",
33-
"firebase": "~1.1.x"
32+
"js-data": ">=1.2.0",
33+
"firebase": ">=1.1.x"
3434
}
3535
}

dist/js-data-firebase.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/**
22
* @author Jason Dobry <[email protected]>
33
* @file js-data-firebase.js
4-
* @version 1.0.0 - Homepage <http://www.js-data.iojs-data-firebase/>
4+
* @version 1.0.1 - Homepage <http://www.js-data.iojs-data-firebase/>
55
* @copyright (c) 2014 Jason Dobry
66
* @license MIT <https://github.com/js-data/js-data-firebase/blob/master/LICENSE>
77
*
88
* @overview Firebase adapter for js-data.
99
*/
10-
!function(e){if("object"==typeof exports&&"undefined"!=typeof module)module.exports=e();else if("function"==typeof define&&define.amd)define([],e);else{var f;"undefined"!=typeof window?f=window:"undefined"!=typeof global?f=global:"undefined"!=typeof self&&(f=self),f.DSFirebaseAdapter=e()}}(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
10+
(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.DSFirebaseAdapter = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
1111
var hasOwn = require('./hasOwn');
1212

1313
var _hasDontEnumBug,
@@ -192,7 +192,12 @@ dsFirebaseAdapterPrototype.find = function (resourceConfig, id, options) {
192192
var _this = this;
193193
return new P(function (resolve, reject) {
194194
return _this.getRef(resourceConfig, options).child(id).once('value', function (dataSnapshot) {
195-
resolve(dataSnapshot.val());
195+
var item = dataSnapshot.val();
196+
if (!item) {
197+
reject(new Error('Not Found!'));
198+
} else {
199+
resolve(item);
200+
}
196201
}, reject, _this);
197202
});
198203
};

dist/js-data-firebase.min.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js-data-firebase.min.map

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
File renamed without changes.

example/example.js renamed to examples/example.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
(function () {
22
angular.module('firebase-example', ['js-data'])
3-
.factory('store', function () {
4-
var store = new JSData.DS();
5-
6-
store.registerAdapter('firebase', new DSFirebaseAdapter({
7-
basePath: 'https://js-data-firebase.firebaseio.com'
8-
}), { default: true });
9-
10-
return store;
3+
.config(function (DSFirebaseAdapterProvider) {
4+
DSFirebaseAdapterProvider.defaults.basePath = 'https://js-data-firebase.firebaseio.com';
5+
})
6+
.run(function (DS, DSFirebaseAdapter) {
7+
// js-data-angular created a new store automatically and registered it as DS.
8+
// The firebase adapter was already registered, but we want to make it the default.
9+
DS.registerAdapter('firebase', DSFirebaseAdapter, { default: true });
1110
})
12-
.factory('User', function (store) {
13-
return store.defineResource('user');
11+
.factory('User', function (DS) {
12+
return DS.defineResource('user');
1413
})
1514
.controller('firebaseCtrl', function ($scope, User) {
1615
var fCtrl = this;
File renamed without changes.

0 commit comments

Comments
 (0)