Skip to content

Commit ececfef

Browse files
committed
DSLocalStorageAdapter.update now returns the updated item.
1 parent cb134e9 commit ececfef

File tree

5 files changed

+39
-18
lines changed

5 files changed

+39
-18
lines changed

Diff for: Gruntfile.js

+19-1
Original file line numberDiff line numberDiff line change
@@ -344,13 +344,31 @@ module.exports = function (grunt) {
344344
grunt.file.write(filePath, file);
345345
});
346346

347+
grunt.registerTask('banner', function () {
348+
var file = grunt.file.read('dist/angular-data.js');
349+
350+
var banner = '/**\n' +
351+
'* @author Jason Dobry <[email protected]>\n' +
352+
'* @file angular-data.js\n' +
353+
'* @version ' + pkg.version + ' - Homepage <http://angular-data.codetrain.io/>\n' +
354+
'* @copyright (c) 2014 Jason Dobry <https://github.com/jmdobry/>\n' +
355+
'* @license MIT <https://github.com/jmdobry/angular-data/blob/master/LICENSE>\n' +
356+
'*\n' +
357+
'* @overview Data store for Angular.js.\n' +
358+
'*/\n';
359+
360+
file = banner + file;
361+
362+
grunt.file.write('dist/angular-data.js', file);
363+
});
364+
347365
grunt.registerTask('test', ['clean:coverage', 'karma:dev']);
348366
grunt.registerTask('doc', ['clean:doc', 'docular', 'concat', 'copy', 'clean:afterDoc', 'uglify:scripts']);
349367
grunt.registerTask('build', [
350368
'clean',
351369
'jshint',
352370
'browserify',
353-
'version:dist/angular-data.js',
371+
'banner',
354372
'uglify:main'
355373
]);
356374
grunt.registerTask('go', ['build', 'watch']);

Diff for: dist/angular-data.js

+13-11
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/**
2-
* @author Jason Dobry <[email protected]>
3-
* @file angular-data.js
4-
* @version 0.9.0 - Homepage <http://angular-data.codetrain.io/>
5-
* @copyright (c) 2014 Jason Dobry <https://github.com/jmdobry/>
6-
* @license MIT <https://github.com/jmdobry/angular-data/blob/master/LICENSE>
7-
*
8-
* @overview Data store for Angular.js.
9-
*/
2+
* @author Jason Dobry <[email protected]>
3+
* @file angular-data.js
4+
* @version 0.9.0 - Homepage <http://angular-data.codetrain.io/>
5+
* @copyright (c) 2014 Jason Dobry <https://github.com/jmdobry/>
6+
* @license MIT <https://github.com/jmdobry/angular-data/blob/master/LICENSE>
7+
*
8+
* @overview Data store for Angular.js.
9+
*/
1010
require=(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({"QYwGEY":[function(require,module,exports){
1111
(function (global){
1212
// Copyright 2012 Google Inc.
@@ -1805,7 +1805,9 @@ function DSLocalStorageProvider() {
18051805
DSUtils.makePath(options.baseUrl || resourceConfig.baseUrl, resourceConfig.endpoint, id),
18061806
attrs,
18071807
options
1808-
);
1808+
).then(function () {
1809+
return GET(DSUtils.makePath(options.baseUrl || resourceConfig.baseUrl, resourceConfig.endpoint, id));
1810+
});
18091811
}
18101812
}];
18111813
}
@@ -4984,7 +4986,7 @@ module.exports = [function () {
49844986
* Load `dist/angular-data.js` or `dist/angular-data.min.js` onto your web page after Angular.js.
49854987
*
49864988
* #### Manual download
4987-
* Download angular-data-0.9.0.js from the [Releases](https://github.com/jmdobry/angular-data/releases)
4989+
* Download angular-data-<%= pkg.version %>.js from the [Releases](https://github.com/jmdobry/angular-data/releases)
49884990
* section of the angular-data GitHub project.
49894991
*
49904992
* ## Load into Angular
@@ -5123,4 +5125,4 @@ module.exports = [function () {
51235125

51245126
},{"mout/array/contains":3,"mout/array/filter":4,"mout/array/slice":8,"mout/array/sort":9,"mout/array/toLookup":10,"mout/lang/isEmpty":15,"mout/object/deepMixIn":22,"mout/object/forOwn":24,"mout/object/pick":27,"mout/object/set":28,"mout/string/makePath":29,"mout/string/upperCase":30}],"utils":[function(require,module,exports){
51255127
module.exports=require('K0yknU');
5126-
},{}]},{},[61])
5128+
},{}]},{},[61])

Diff for: dist/angular-data.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: src/adapters/localStorage.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ function DSLocalStorageProvider() {
173173
DSUtils.makePath(options.baseUrl || resourceConfig.baseUrl, resourceConfig.endpoint, id),
174174
attrs,
175175
options
176-
);
176+
).then(function () {
177+
return GET(DSUtils.makePath(options.baseUrl || resourceConfig.baseUrl, resourceConfig.endpoint, id));
178+
});
177179
}
178180
}];
179181
}

Diff for: test/integration/adapters/localStorage/update.test.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('DSLocalStorageAdapter.update(resourceConfig, id, attrs, options)', fun
1010
baseUrl: 'api',
1111
endpoint: 'posts'
1212
}, 1, { author: 'Sally' }).then(function (data) {
13-
assert.isUndefined(data, 'data should be undefined');
13+
assert.deepEqual(data, { author: 'Sally', age: 30, id: 5 }, 'data should have been updated');
1414
assert.deepEqual(angular.fromJson(localStorage.getItem(path)), { author: 'Sally', age: 30, id: 5 }, 'p1 should be in localStorage');
1515

1616
path = DSUtils.makePath('api2', 'posts', 2);
@@ -23,8 +23,7 @@ describe('DSLocalStorageAdapter.update(resourceConfig, id, attrs, options)', fun
2323
baseUrl: 'api',
2424
endpoint: 'posts'
2525
}, 2, { age: 44 }, { baseUrl: 'api2' }).then(function (data) {
26-
assert.isUndefined(data, 'data should be undefined');
27-
26+
assert.deepEqual(data, { author: 'Sally', age: 44, id: 6 }, 'data should have been updated');
2827
assert.deepEqual(angular.fromJson(localStorage.getItem(path)), { author: 'Sally', age: 44, id: 6 }, 'p1 should be in localStorage');
2928

3029
done();

0 commit comments

Comments
 (0)