-
Notifications
You must be signed in to change notification settings - Fork 264
Possible typo on animate
API documentation
#1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Taking a look at the documentation the paragraph saying:
Is referring to the examples right below it, not the one above, if you take a look at the example below the paragraph it actually expands the div out to 90% width: <script>
$( "#go1" ).on( "click", function() {
$( "#block1" )
.animate({
width: "90%"
}, {
queue: false,
duration: 3000
})
.animate({ fontSize: "24px" }, 1500 )
.animate({ borderRightWidth: "15px" }, 1500 );
});
</script> It might be a good thing to change the order of the paragraphs/examples for better clarity and/or just move the mentioned paragraph and position it below the "correct" example. |
Probably appending "In the next example" i.e:
would increase clarity and remove the ambiguity of "is this text referring to the example above? or the one below?" |
I don't think that's the correct approach; we'd have to add something like that to every single example. I'd rather tweak the The Maybe we should have a header (h3?) for each example with the counter (Example 1, Example 2, etc.) which would separate them more clearly? |
Yeah, sure, that would be a great change, I'll take a look at the files you mentioned and see if I can make the changes |
If there's more than one example append an `<h3>` tag with the number of the example, e.g. "Example 1". Closes gh-95 Ref jquery/api.jquery.com#1157 Ref jquery/jquery-wp-content#481
This has been fixed and examples are more clearly separated now. Thanks to @aldimar-junior for the fix! |
Hello! There may be a possible typo on the
animate
API documentation.In the example shown, the code is:
However, the next paragraph explaining it says that:
It is my understanding that the
animate
method expands thediv
out to 70% width, since the value for thewidth
property in the properties object is 70%.Thank you for reading this and have a great day.
The text was updated successfully, but these errors were encountered: