forked from green-code-initiative/creedengo-java
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathMakeVariableConstant.java
More file actions
54 lines (46 loc) · 2.31 KB
/
MakeVariableConstant.java
File metadata and controls
54 lines (46 loc) · 2.31 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
/*
* ecoCode - Java language - Provides rules to reduce the environmental footprint of your Java programs
* Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
public class MakeVariableConstant {
private static final int constant = 0; // ok
private int varDefinedInClassNotReassigned = 0; // Noncompliant {{Make variable constant}}
private int varDefinedInClassReassigned = 0; // ok
void changeVarDefinedInClassReassigned() {
varDefinedInClassReassigned = 1;
System.out.println("varDefinedInClassReassigned = " + varDefinedInClassReassigned);
System.out.println("varDefinedInClassNotReassigned = " + varDefinedInClassNotReassigned);
System.out.println("constant = " + constant);
}
void simpleMethod() {
String varDefinedInMethodNotReassigned = "hello"; // Noncompliant {{Make variable constant}}
String varDefinedInMethodReassigned = "hello"; // ok
varDefinedInMethodReassigned = "bye";
System.out.println("varDefinedInMethodNotReassigned = " + varDefinedInMethodNotReassigned);
System.out.println("varDefinedInMethodReassigned = " + varDefinedInMethodReassigned);
}
/*
void methodWithFor() {
double varDefinedInMethodForNotReassigned = 1.0d; // Noncompliant {{Make variable constant}}
double varDefinedInMethodForReassigned = 100.0d; // ok
for (int i = 0; i < 10; i++) {
varDefinedInMethodForReassigned += i;
}
System.out.println("varDefinedInMethodForNotReassigned = " + varDefinedInMethodForNotReassigned);
System.out.println("varDefinedInMethodForReassigned = " + varDefinedInMethodForReassigned);
}
*/
}