-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix controlled date picker set to null #4459
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -214,7 +214,7 @@ export const DateInputRange = forwardRef< | |||
endInputRef: endInputRefProp, | |||
locale, | |||
parse: parseProp, | |||
placeholder = "dd mmm yyyy", | |||
placeholder = format, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah.. the case has changed :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casing actually matters, in certain library, lower case and upper case means different things.
replace by #4465 |
#4344
Questions to be answered
undefined
vsnull
vsDate
(invalid vs valid)DateInputSingle
useEffect
: sync input value state to the date statedate
is controlled to benull
, we want to clear the inputdate
is controlled to be a valid date, we want the formatted input value in the inputdate
is controlled to be a invalid date, we want leave as it isapply
DatePickerSingleInput
vsDateInputSingle