Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-color dependency #162

Open
Tracked by #1055
origami-z opened this issue Jun 8, 2022 · 2 comments
Open
Tracked by #1055

Remove react-color dependency #162

origami-z opened this issue Jun 8, 2022 · 2 comments
Labels
package: lab Lab package

Comments

@origami-z
Copy link
Contributor

origami-z commented Jun 8, 2022 •
edited
Loading

The ColorPicker component uses react-color for some visualisation, which we need to replace mostly due to bundle size.

https://bundlephobia.com/package/@jpmorganchase/[email protected]

Only SketchPicker is used in ColorPicker, and it should be replaceable by some gradients and drag/drop events.

Color Picker
@origami-z origami-z added the package: lab Lab package label Jun 13, 2022
@joshwooding
Copy link
Contributor

https://colorjs.io/ might be useful

@joshwooding joshwooding mentioned this issue Jun 5, 2024
Merged
@origami-z origami-z mentioned this issue Nov 8, 2024
Open
@chrispcode
Copy link
Contributor

[email protected] has now tree shaking, and we use that version, so react-color isn't a significant part of the lab bundle anymore.

image

https://bundlephobia.com/package/@salt-ds/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: lab Lab package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@origami-z @chrispcode @joshwooding