Skip to content

Commit

Permalink
fix: Remove unnecessary copy method overload in MetaManager
Browse files Browse the repository at this point in the history
* Correct `sync` arg to `True` in `MetaManagerShared` for `exists` method

Signed-off-by: Mahendra Paipuri <[email protected]>
  • Loading branch information
mahendrapaipuri committed Jun 13, 2024
1 parent 03015c8 commit 5de2aba
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions jupyterfs/metamanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def root_dir(self):
is_hidden = path_first_arg("is_hidden", False, sync=True)
dir_exists = path_first_arg("dir_exists", False, sync=True)
file_exists = path_kwarg("file_exists", "", False, sync=True)
exists = path_first_arg("exists", False, sync=False)
exists = path_first_arg("exists", False, sync=True)

save = path_second_arg("save", "model", True, sync=True)
rename = path_old_new("rename", False, sync=True)
Expand All @@ -170,9 +170,6 @@ class SyncMetaManager(MetaManagerShared, ContentsManager): ...


class MetaManager(MetaManagerShared, AsyncContentsManager):
async def copy(self, from_path, to_path=None):
return super(MetaManagerShared, self).copy(from_path=from_path, to_path=to_path)

is_hidden = path_first_arg("is_hidden", False, sync=False)
dir_exists = path_first_arg("dir_exists", False, sync=False)
file_exists = path_kwarg("file_exists", "", False, sync=False)
Expand Down

0 comments on commit 5de2aba

Please sign in to comment.