Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour when mapping two source folders to one destination folder #653

Open
LMG opened this issue Mar 7, 2022 · 1 comment
Open

Behaviour when mapping two source folders to one destination folder #653

LMG opened this issue Mar 7, 2022 · 1 comment

Comments

@LMG
Copy link
Collaborator

LMG commented Mar 7, 2022

In the case where the following mappings are present:

a = :/a
a = :/b

The contents of the folder should be the contents of :/b ovelaid on :/a. Correct?

Then when pushing, the contents of the destination a should be pushed to :/b, leaving :/a empty (and looking like we deleted them to the source server). Correct?

Unfortunately, this is not the behaviour we observe, and I'm confused as to why.

We see that the extra files from :/a are pushed to :/b, but the other, shadowed files are not modified in any way in either folder.

Any idea?

Also, we definitely need a way to detect and warn about this particular case, in the workspace warnings API. This is a feature which is useful in some cases (pulling a bunch of folders into one) but almost always unwanted in a workspace.josh.

@LMG
Copy link
Collaborator Author

LMG commented Mar 7, 2022

I suppose this relates to this: https://github.com/josh-project/josh/blob/master/tests/filter/workspace_shadow_file.t and the behaviour changed recently with the unapply of exclude. So maybe that explains that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant