-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue: Extremely slow, unpredictable cloning when using HTTPS with GitHub #1375
Comments
Ni @nrdxp, |
Right I just didn't know if anything was missing, because as I reported, it doesn't prompt me for credentials, it just hangs indefinitely. At first I thought it might be something in my git config so I tried with an empty one and same result, perhaps its a genuine bug then? I know github had some issues last week too, so I will try again sometime today and see if perhaps it works better. |
It seems to be genuinely stuck in a loop, so perhaps I should retitle this issue as a bug:
If I wait a really long time, it finally goes through? Is this because nixpkgs is just exceptionally large, perhaps? Or maybe a ratelimit on GH's end? edit |
I've updated the original post to reflect my evolving understanding of the issue. Initially thought to be an authentication problem, then a potential infinite loop, it now appears to be a performance issue possibly related to rate limiting (which might be due to missing auth). The updated OP provides a more accurate description of the observed behavior and potential causes. |
I don't think this is due to missing auth. As far as I understand the git client will always first attempt to do the request without auth and then only supply credentials when the server asks for them. For cloning a public repo there should be no credentials required. So I'm wondering why this is an issue. The clone should just succeed without credentials being transmitted. Regarding performance: On a first clone it is also expected to take some time for such a large repo, however follow up fetch/pull (or clone using the same proxy instance) should be fast though. Another thing would be to try josh@ 012f8dc as I do suspect a bug regarding auth/performance has been introduced after, but I was not able to reproduce it so far. |
Issue Description
When attempting to use a local josh-proxy instance targeting GitHub via HTTPS, I'm experiencing extremely slow performance during the cloning process. The time to complete a clone operation ranges from a few seconds to over 10 minutes, which seems to defeat josh's purpose of being "blazingly fast".
Observed Behavior
git clone
command appears to hang indefinitely.Attempted Solutions
--required-auth
flag.Potential Cause
The slow performance might be due to GitHub rate limiting caused by missing authentication. The logs suggest that authentication information is not being passed through correctly.
Questions
Additional Information
Any insights or suggestions for further debugging would be greatly appreciated.
The text was updated successfully, but these errors were encountered: