You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Unlike in JavaScript, numeric literals cannot be used as plain object keys.
To Reproduce math.evaluate('{0: 12-7, 1: 8+2}[2-2]') throws SyntaxError: Symbol or string expected as object key (char 2).
Discussion
It appears that the parser knows exactly what the situation is, which suggests there is no technical reason why this expression couldn't be allowed in the mathjs expression language. Given that it is perfectly legal in JavaScript and evaluates to 5 as expected, I would recommend that the mathjs parser be extended to accept numeric literals as object keys.
In order for this to be useful, the mathjs evaluator will also need to be extended to allow numeric values in indexing into plain objects: currently math.evaluate('{"0": 12-7, "1": 8+2}[2-2]') throws TypeError: Cannot apply a numeric index as object property
Workaround for now
One can convert both the keys and the index expressions to strings: math.evaluate('{"0": 12-7, "1": 8+2}[string(2-2)]') produces 5 as expected. But this is of course cumbersome.
The text was updated successfully, but these errors were encountered:
Yeah I guess it's fine to relax the parser and allow numeric keys. I think it would be good though to not support the dot notation (I think JS doesn't support that either).
Great, as soon as I can I will work up a PR. As far as a numeric argument with dot notation, currently if foo=[3,4,5], then foo.1 returns [0.3, 0.4, 0.5] because it is interpreted as implicit multiplication. Unless you want to change this behavior and change it to an error because it's more likely to be someone mistakenly trying to use dot notation with a number, I would plan to leave that behavior alone.
Thanks Glen. I agree that the most common case when someone enters foo.1 is to use dot notation and not implicit multiplication. I think it is ok to leave it as it is now, it is a bit of an edge case. If people run into issues with this we can implement throwing an error (asking the use to either use foo[1] or foo 0.1), but that will be a breaking change.
Describe the bug
Unlike in JavaScript, numeric literals cannot be used as plain object keys.
To Reproduce
math.evaluate('{0: 12-7, 1: 8+2}[2-2]')
throwsSyntaxError: Symbol or string expected as object key (char 2)
.Discussion
It appears that the parser knows exactly what the situation is, which suggests there is no technical reason why this expression couldn't be allowed in the mathjs expression language. Given that it is perfectly legal in JavaScript and evaluates to 5 as expected, I would recommend that the mathjs parser be extended to accept numeric literals as object keys.
In order for this to be useful, the mathjs evaluator will also need to be extended to allow numeric values in indexing into plain objects: currently
math.evaluate('{"0": 12-7, "1": 8+2}[2-2]')
throwsTypeError: Cannot apply a numeric index as object property
Workaround for now
One can convert both the keys and the index expressions to strings:
math.evaluate('{"0": 12-7, "1": 8+2}[string(2-2)]')
produces 5 as expected. But this is of course cumbersome.The text was updated successfully, but these errors were encountered: