fix: Move ext-intl and ext-bcmath out of require and into suggest blo… #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck (closes #187)
Relates to #187
There is existing code to check that
ext-intlandext-bcmathare installed. Including them in the require block ofcomposer.jsonis too restrictive and does no allow this package to be used on systems without them even thoughext-intlis only used forspellout()and SimpleCalculator can be used instead of BinaryCalculator.This change moves them into the composer
suggestblock instead, allowing the code to throw exceptions where necessary.