Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electricity/Energy Values Inquiry #156

Open
brysonreece opened this issue Sep 23, 2020 · 1 comment
Open

Electricity/Energy Values Inquiry #156

brysonreece opened this issue Sep 23, 2020 · 1 comment

Comments

@brysonreece
Copy link

brysonreece commented Sep 23, 2020

Hey there, awesome package!

I was wanting to inquire; are there any future plans for implementing "Electricity" values or perhaps expanding the Energy namespace to include units and conversions for things like Voltage/Amperage/Wattage?

Thanks so much!

/label ~"Type: Enhancement"

@jordanbrauer
Copy link
Owner

jordanbrauer commented Sep 28, 2020

Greetings, @brysonreece ! And, thank you!

are there any future plans for implementing "Electricity" values or perhaps expanding the Energy namespace to include units and conversions for things like Voltage/Amperage/Wattage?

Indeed, there is! Number #84 mentions adding the ampere (amp) as a new base SI unit (along with some others that the package still lacks). I've unfortunately been very busy with my own day job, so I've had to put my own work on the package down for now (though it looks I will have some time within the next month for Hacktoberfest!). So, if you'd like to start a PR, I would be more than happy to review it and pull it in to the project!

The goal of the package is to complete the seven base SI units – currently four are present (time, length, mass, and temperature), and the other three are mentioned in #84 . Should you choose to submit a PR, we can mark that one off the list and close this issue!


I'm thinking one of the following namespaces will fit well;

namespace UnitConverter\Unit\Electricity;
namespace UnitConverter\Unit\Current;
namespace UnitConverter\Unit\ElectricalCurrent;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants