Skip to content

[6.0] Improved removal of unnecessary fields and empty fieldsets #46039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.0-dev
Choose a base branch
from
+45 −90
Open

[6.0] Improved removal of unnecessary fields and empty fieldsets #46039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 1 addition & 90 deletions plugins/fields/note/params/note.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<form>
<field
name="required"
type="hidden"
filter="unset"
/>

<field
name="default_value"
type="hidden"
filter="unset"
/>
<fields name="params" label="COM_FIELDS_FIELD_BASIC_LABEL">
<fieldset name="basic">
<field
name="hint"
type="hidden"
filter="unset"
/>

<field
name="class"
type="hidden"
filter="unset"
/>

<field
name="label_class"
type="hidden"
filter="unset"
/>

<field
name="show_on"
type="hidden"
filter="unset"
/>

<field
name="showon"
type="hidden"
filter="unset"
/>

<field
name="showlabel"
type="hidden"
filter="unset"
/>

<field
name="label_render_class"
type="hidden"
filter="unset"
/>

<field
name="render_class"
type="hidden"
filter="unset"
/>

<field
name="value_render_class"
type="hidden"
filter="unset"
/>

<field
name="prefix"
type="hidden"
filter="unset"
/>

<field
name="suffix"
type="hidden"
filter="unset"
/>

<field
name="display_readonly"
type="hidden"
filter="unset"
/>

<field
name="searchindex"
type="hidden"
filter="unset"
/>
</fieldset>
<fieldset name="renderoptions">
<field
name="display_frontend"
Expand Down Expand Up @@ -148,6 +58,7 @@
type="text"
label="PLG_FIELDS_NOTE_PARAMS_CLOSE_LABEL"
description="PLG_FIELDS_NOTE_PARAMS_CLOSE_DESC"
default="true"
/>
</fieldset>
</fields>
Expand Down
44 changes: 44 additions & 0 deletions plugins/fields/note/src/Extension/Note.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@

namespace Joomla\Plugin\Fields\Note\Extension;

use Joomla\CMS\Event\Model\PrepareFormEvent;
use Joomla\Component\Fields\Administrator\Plugin\FieldsPlugin;
use Joomla\Event\SubscriberInterface;
use Joomla\Utilities\ArrayHelper;

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
Expand All @@ -24,4 +26,46 @@
*/
final class Note extends FieldsPlugin implements SubscriberInterface
{
/**
* The form event. Load additional parameters when available into the field form.
* Only when the type of the form is of interest.
*
* @return void
*
* @since __DEPLOY_VERSION__
*/
public function prepareForm(PrepareFormEvent $event)
{
parent::prepareForm($event);

$form = $event->getForm();
$data = $event->getData();

$type = ArrayHelper::getValue((array) $data, 'type');

if (!$this->getApplication()->isClient('administrator') || $form->getName() !== 'com_fields.field.com_content.article' || $type !== 'note') {
return;
}

$form->removeField('default_value');
$form->removeField('required');
$form->removeField('hint', 'params');
$form->removeField('class', 'params');
$form->removeField('label_class', 'params');
$form->removeField('showlabel', 'params');
$form->removeField('label_render_class', 'params');
$form->removeField('render_class', 'params');
$form->removeField('value_render_class', 'params');
$form->removeField('show_on', 'params');
$form->removeField('prefix', 'params');
$form->removeField('suffix', 'params');
$form->removeField('display_readonly', 'params');

$xml = $form->getXml();

foreach ($xml->xpath('//fieldset[@name="smartsearchoptions"]') as $fieldset) {
$dom = dom_import_simplexml($fieldset);
$dom->parentNode->removeChild($dom);
}
}
}
Loading