Fix permission denied while writing to temporary file on Windows #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by the file already being opened when instantiating the NamedTemporaryFile. Windows cannot handle this. See https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile and https://stackoverflow.com/a/23212515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by the file already being opened when instantiating the NamedTemporaryFile. Windows cannot handle this. See https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile and https://stackoverflow.com/a/23212515
This should fix johndoe31415/pdfminify#17. However, I usually do not code in python. Therefore review and test my changes carefully. I did not find any tests related to the method.
⚠️ These changes are untested because I lack the setup. ⚠️