Dockerize Storage

[faqndo97]

Hi!

I just forked the project and I'm seeing we need to install Postgres and Redis for the project. One tactic that I've been using for some time is to have a docker-compose.yml just to initialize the storage (Postgres and Redis in this case).

Here is an example of a docker-compose from another project. Pretty simple and small but reduce the number of things to have installed in the devs' machine and ensure everyone uses the same versions of them.

version: '3'

services:
  postgres:
    image: postgres:13
    ports:
      - "${POSTGRES_PORT}:5432"
    restart: always
    environment:
      POSTGRES_USER: "${POSTGRES_USER}"
      POSTGRES_PASSWORD: "${POSTGRES_PASSWORD}"
    volumes:
      - pg_data:/var/lib/postgresql/data
  redis:
    image: redis:latest
    ports:
      - "${REDIS_PORT}:6379"
    restart: always
    volumes:
      - redis_data:/data
volumes:
  pg_data: {}
  redis_data: {}

Would you be interested in adding this here?

[joemasilotti]

Hey @faqndo97, thanks for the idea.

I don't currently use Docker so I don't feel comfortable bringing it in to the project. I don't want to be stuck maintaining something I know very little about.

You are free to use this for your own machine, though!

[robzolkos]

I would encourage this to be revisited. I just spent over an hour trying to get the project working on my local machine so I could contribute a PR and gave up. I can't lay blame on the codebase or my machine being the issue but docker removes the question entirely. For the sake of <25 lines of config that is completely optional to use for devs that don't use docker I think the pros far outweight the cons. Another way of looking at it is either maintain 25+ lines of setup code in the README, or provide 25 lines of docker config that is guaranteed to work for everyone consistently. Either way there is a maintenance cost but surely removing barriers to contributors is a win?

[joemasilotti]

Either way there is a maintenance cost but surely removing barriers to contributors is a win?

Agreed. I don't feel comfortable maintaining code that I won't ever use and don't know what it does (and can't even debug it myself!).

That said, if you or @faqndo97 are willing to maintain the configuration then I am happy to merge a PR.

[faqndo97]

I just read this, of @robzolkos didn’t create a PR I’ll send one this weekend with at least the storages. What do you think?

[joemasilotti]

If you are willing to maintain it then I will accept a PR.