Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to nan #135

Closed
jsdevel opened this issue Jul 12, 2014 · 11 comments
Closed

Moving to nan #135

jsdevel opened this issue Jul 12, 2014 · 11 comments

Comments

@jsdevel
Copy link
Collaborator

jsdevel commented Jul 12, 2014

@joeferner I rebased the use-nan branch so your changes now appear on top of the latest. Let me know if this causes any issues for you.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 14, 2014

It looks like memwatch ~0.2.0 is currently failing the node 0.11 build in travis. This PR has an update for it to use nan: lloyd/node-memwatch#56

@joeferner
Copy link
Owner

Other than memwatch it looks like the nan branch works with v0.10.29 of node. I wonder if we should either remove memwatch since it's only used in integration tests or we could use the pull request's git url which is discouraged.

My vote is removing the memwatch dependency.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 14, 2014

@joeferner I'm down with removing it.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 14, 2014

memwatch removed.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 16, 2014

@joeferner Can you take a look at this? https://github.com/joeferner/node-java/blob/use-nan/src/methodCallBaton.cpp#L67

I have a feeling the scope is getting cleared when the callback is called, thus erasing the value. This only happens on 0.11. Everything else is compiling fine.

@joeferner
Copy link
Owner

After switching MethodCallBaton to use NanAsyncWorker it looks like it works on 0.11 and 0.10 for me.

@joeferner
Copy link
Owner

Are we ready to merge the use-nan branch?

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 16, 2014

Looks like we are with a passing build!

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 17, 2014

@joeferner use-nan is merged with master now. I bumped to v0.4.0. Can you publish?

@joeferner
Copy link
Owner

Awesome this is really great. @jsdevel thanks for all your help.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jul 17, 2014

My pleasure. I feel like I learned a lot about v8 so I appreciate the opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants