Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications reissued upon feed refresh #781

Open
shift18 opened this issue Jan 27, 2025 · 11 comments
Open

Notifications reissued upon feed refresh #781

shift18 opened this issue Jan 27, 2025 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@shift18
Copy link

shift18 commented Jan 27, 2025

Steps to Reproduce

  1. Add feeds to cappy
  2. Enable notifications for feeds
  3. Cappy seem to renotify every unread article in each feed each time cappy refreshes the feeds

Expected behavior

Notification are to be issued only once when an article has been downloaded, not upon feed refresh.

This issue appeard during the last couple of months.

Screenshots or screen recording

No response

Device, Operating system, and app version

version 2025.01.1097

com.capyreader.app
versionCode 1097

targetSdk 35
minSdk 30

Installed: Oct 18, 2024; 13:06
Updated: Jan 23, 2025; 09:44

OS:GOS ANDROID 15

@shift18 shift18 added the bug Something isn't working label Jan 27, 2025
@jocmp
Copy link
Owner

jocmp commented Jan 28, 2025

Thanks for the bug report @shift18. Just to help me debug, are you using local feeds or a sync service like FreshRSS or Feedbin?

@jocmp jocmp moved this to On Deck in Capy Reader Jan 28, 2025
@shift18
Copy link
Author

shift18 commented Jan 28, 2025

Thanks for the bug report @shift18. Just to help me debug, are you using local feeds or a sync service like FreshRSS or Feedbin?

Local feeds only
Oh, and thank you for looking into this issue!

@jocmp jocmp moved this from On Deck to In Progress in Capy Reader Jan 28, 2025
@jocmp jocmp self-assigned this Jan 29, 2025
@jocmp jocmp moved this from In Progress to Next Release in Capy Reader Feb 2, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 2, 2025

Hey @shift18, I have a fix for this in 2025.02.1101 that should ignore unread articles that have already been notified.

Let me know if you still see odd behavior after that, and thanks again for the bug report!

@jocmp jocmp closed this as completed Feb 2, 2025
@github-project-automation github-project-automation bot moved this from Next Release to Done in Capy Reader Feb 2, 2025
@shift18
Copy link
Author

shift18 commented Feb 2, 2025

Thanks alot @jocmp
Those persistent notifications where driving me nuts!

@shift18
Copy link
Author

shift18 commented Feb 4, 2025

@jocmp
Hmm, unfortunately the issue seems to persist despite your efforts to fix it.

P.S. Received the update through google play today so I'll monitor the issue a while longer just to make sure.

version 2025.02.1101

com.capyreader.app
versionCode 1101

targetSdk 35
minSdk 30

@jocmp
Copy link
Owner

jocmp commented Feb 5, 2025

Gotcha. @shift18 do you notice any patterns, for instance, is it just for some feeds and not others? Happy to investigate more if you keep seeing it.

@shift18
Copy link
Author

shift18 commented Feb 6, 2025

Gotcha. @shift18 do you notice any patterns, for instance, is it just for some feeds and not others? Happy to investigate more if you keep seeing it.

No, can't say that i do.
Unread articles just are just being reannounced multiple times an hour, capy readers is set to refresh the feeds every 30 min and my assumption is that this is when the the articles gets reannounced.
Furthermore This happens even with articles that are hours old (according to the timestamp found in capy) so it's not like articles are being reissued by the feed hosts either.

@jocmp
Copy link
Owner

jocmp commented Feb 6, 2025

Would you be willing to send me a feed that this is happening to? It could be feed specific if the article identifier changes for instance.

@jocmp jocmp reopened this Feb 6, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 6, 2025

note to self:

  • right join instead of left join
  • ensure updated_at isn't reset on refresh

@jocmp jocmp moved this from Done to On Deck in Capy Reader Feb 6, 2025
@jocmp jocmp moved this from On Deck to In Progress in Capy Reader Feb 6, 2025
@jocmp jocmp moved this from In Progress to Next Release in Capy Reader Feb 8, 2025
@jocmp
Copy link
Owner

jocmp commented Feb 10, 2025

@shift18 I added another fix for this in 2025.02.1103 to avoid reissuing notifications if one was already posted. My hunch right now is that GrapheneOS doesn't broadcast when notifications are dismissed the same way that stock Android 15 does.

I'll leave this issue open just in case you still see any issues. Let me know!

@jocmp jocmp moved this from Next Release to Parking Lot in Capy Reader Feb 10, 2025
@shift18
Copy link
Author

shift18 commented Feb 10, 2025

thanks for all your efforts @jocmp
I'd expect GOS to handle notifications the same way as ASOP.

The GOS devs practically never never change stuff unless it enhances the security or privacy of the OS.
The only occasional expectation to this rules is to be found if the community desires a feature found in the stock os (ASOP + Googles very own special sauce)

Yes, if I have any further issues I'll definitely let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Parking Lot
Development

No branches or pull requests

2 participants